feat: unset module translations if no translatable fields for types

Author: didoda

src/Controller/Component/ModulesComponent.php

@@ -166,10 +166,33 @@ function (&$data, $key) use ($metaModules): void {
         if (!$this->Schema->tagsInUse()) {
             unset($this->modules['tags']);
         }
+        $types = array_keys($this->modules);
+        if (isset($this->modules['translations']) && !$this->translationsEnabled($types)) {
+            unset($this->modules['translations']);
+        }
 
         return $this->modules;
     }
 
+    /**
+     * Check if translations are enabled for at least one of the given object types.
+     *
+     * @param array $types Object types to check.
+     * @return bool
+     */
+    public function translationsEnabled(array $types): bool
+    {
+        foreach ($types as $objectType) {
+            $schema = (array)$this->Schema->getSchema($objectType);
+            $translatable = (array)Hash::get($schema, 'translatable');
+            if (count($translatable) > 0) {
+                return true;
+            }
+        }
+
+        return false;
+    }
+
     /**
      * This filters modules and apply 'AccessControl' config by user role, if any.
      * Module can be "hidden": remove from modules.

tests/TestCase/Controller/Component/ModulesComponentTest.php

@@ -72,6 +72,7 @@
 #[CoversMethod(ModulesComponent::class, 'skipSavePermissions')]
 #[CoversMethod(ModulesComponent::class, 'skipSaveRelated')]
 #[CoversMethod(ModulesComponent::class, 'startup')]
+#[CoversMethod(ModulesComponent::class, 'translationsEnabled')]
 #[CoversMethod(ModulesComponent::class, 'upload')]
 class ModulesComponentTest extends TestCase
 {
@@ -588,6 +589,18 @@ function ($param) use ($meta, $modules) {
                         return compact('meta');
                     },
                 );
+            $apiClient->method('schema')
+                ->willReturnCallback(
+                    function ($type) {
+                        if ($type === 'bedita') {
+                            return [
+                                'translatable' => ['title', 'body'],
+                            ];
+                        }
+
+                        return [];
+                    },
+                );
         }
         ApiClientProvider::setApiClient($apiClient);