Rebrand glTF coordinate conversion to an alternative strategy that is biased towards glTF models #20131
+95
−160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…version (bevyengine#19816)" This reverts commit fb2bbb0.
janhohenheim
added
D-Straightforward
superdump
reviewed
Jul 14, 2025
superdump
reviewed
Jul 14, 2025
superdump
reviewed
Jul 14, 2025
superdump
reviewed
Jul 14, 2025
Co-authored-by: Robert Swain <[email protected]>
Co-authored-by: Robert Swain <[email protected]>
alice-i-cecile
added
X-Contentious
greeble-dev
approved these changes
Jul 20, 2025
There was a problem hiding this comment.
I'm clicking the approve button as I think backing away from "we will change the default in 0.18" is the right choice given the ongoing discussion.
I have some doubts about the use_model_forward_direction behaviour (see alternative proposal), but I feel this PR is still a step in the right direction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Per long discussion with @superdump (see #19686 (comment)), the new coordinate loading system is still wrong, just now biased in favor of having correct forward semantics for models instead of cameras.
Which is still what I need, but it should not be the new default, as we may well change
Transform::forwardinstead.Solution
Since changing forward semantics is a bigger change, let's rebrand the coordinate conversion code and keep it opt-in so that users that don't use glTF cameras get correct semantics in the meantime.
Testing