-
Notifications
You must be signed in to change notification settings - Fork 190
[ENH][BEP028] Specification update for BEP028 BIDS-Prov #2099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
[ENH] Update to BIDS-Prov specification pull request
|
@cmaumet @bclenet Let's schedule a call: https://www.when2meet.com/?33661829-Yw724 Please forward to anybody you want on there. |
cmaumet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bclenet - thanks a lot for this new version! See some small edits and suggestions.
src/schema/objects/metadata.yaml
Outdated
| name: Digest | ||
| display_name: Digest | ||
| description: | | ||
| Object containing digests of the data described by the provEntity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Object containing digests of the data described by the provEntity. | |
| Object containing digests of the data described by the BIDS file. |
Here we know the provEntity in question is a BIDS file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cmaumet Actually, this is something I wanted to discuss with you ; because it could be nice to allow Digest and Type in dataset_description.json as well. What do you think about that ?
src/schema/objects/metadata.yaml
Outdated
| format: uri | ||
| Type: | ||
| name: Type | ||
| description: A term from a controlled vocabulary that more specifically describes the provEntity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| description: A term from a controlled vocabulary that more specifically describes the provEntity. | |
| description: A term from a controlled vocabulary that more specifically describes the type of the BIDS file. |
| - *sub-001_T1w_preproc.nii* is the skull striped image; | ||
| - the *"Brain extraction"* activity was performed using the *FSL* software within a *Linux* software environment. | ||
|
|
||
| Moreover, the terms defined in this specification to describe provenance are based on the [W3C Prov](https://www.w3.org/TR/2013/REC-prov-o-20130430/) standard. They can be resolved to [IRIs](https://www.w3.org/TR/json-ld11/#iris) using the JSON-LD context file [`provenance-context.json`](../provenance-context.json) provided with this specification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Moreover, the terms defined in this specification to describe provenance are based on the [W3C Prov](https://www.w3.org/TR/2013/REC-prov-o-20130430/) standard. They can be resolved to [IRIs](https://www.w3.org/TR/json-ld11/#iris) using the JSON-LD context file [`provenance-context.json`](../provenance-context.json) provided with this specification. | |
| Moreover, the terms defined in this specification to describe provenance are based on the [W3C Prov](https://www.w3.org/TR/2013/REC-prov-o-20130430/) standard. The corresponding [IRIs](https://www.w3.org/TR/json-ld11/#iris) are describing in the JSON-LD context file [`provenance-context.json`](../provenance-context.json) provided with this specification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean "are describing" or "are described" ?
Yes! I think our messages just crossed each other. I just sent a calendar invite for Dec 4 (4pm my time). Did you get it? (And thanks for following up!) |
Co-authored-by: Camille Maumet <[email protected]>
This is a work in progress PR proposing a specification update for BEP028 BIDS-Prov.
Todo lists
Blocking points
prov/[prov-<label>]BEP028_BIDSprov#169GeneratedByBEP028_BIDSprov#170Associated BIDS examples