Skip to content

fix: general fixes to SDK #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 10, 2025
Merged

fix: general fixes to SDK #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
43bb2a2
[general-fixes] - fix npm audit problem
GuiLeme Sep 24, 2025
9a54cc0
[lad-new-functions-plugin] Removed duplicated lint npm command
GuiLeme Sep 25, 2025
9e2db69
Merge remote-tracking branch 'upstream/v0.0.x' into general-fixes
GuiLeme Sep 25, 2025
099fef6
[general-fixes] fix data-channel type interface containing wrong values
GuiLeme Sep 25, 2025
fc5e3ec
[general-fixes] remove fromUserId from data-channel interface
GuiLeme Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
197 changes: 153 additions & 44 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion samples/sample-action-button-dropdown-plugin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
"scripts": {
"build-bundle": "webpack --mode production",
"start": "webpack serve --mode development",
"lint": "eslint ./src/*",
"build:watch": "rm -rf dist && tsc -w --module CommonJS",
"lint": "eslint ./src/*",
"lint:fix": "npm run lint -- --fix",
Expand Down
1 change: 0 additions & 1 deletion samples/sample-generic-content-sidekick-plugin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
"scripts": {
"build-bundle": "webpack --mode production",
"start": "webpack serve --mode development",
"lint": "eslint ./src/*",
"build:watch": "rm -rf dist && tsc -w --module CommonJS",
"lint": "eslint ./src/*",
"lint:fix": "npm run lint -- --fix"
Expand Down
1 change: 0 additions & 1 deletion samples/sample-server-commands-plugin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
"scripts": {
"build-bundle": "webpack --mode production",
"start": "webpack serve --mode development",
"lint": "eslint ./src/*",
"build:watch": "rm -rf dist && tsc -w --module CommonJS",
"lint": "eslint ./src/*",
"lint:fix": "npm run lint -- --fix"
Expand Down
1 change: 0 additions & 1 deletion samples/sample-user-list-dropdown-plugin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
"scripts": {
"build-bundle": "webpack --mode production",
"start": "webpack serve --mode development",
"lint": "eslint ./src/*",
"build:watch": "rm -rf dist && tsc -w --module CommonJS",
"lint": "eslint ./src/*",
"lint:fix": "npm run lint -- --fix"
Expand Down
2 changes: 1 addition & 1 deletion scripts/validate-samples-code.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ THIS_SCRIPT_PATH=$(dirname "$(readlink -f "$0")")
# Calculate the absolute path of the project directory.
PROJECT_DIR=$(realpath "$THIS_SCRIPT_PATH/..")

for SAMPLE in samples/*/; do
for SAMPLE in $PROJECT_DIR/samples/*/; do
if [ -d "$SAMPLE" ]; then
# Install dependencies if there is no node_modules
if [ ! -d "$SAMPLE/node_modules" ]; then
Expand Down
5 changes: 3 additions & 2 deletions src/data-channel/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,16 +50,17 @@ export interface MapOfPushEntryFunctions {

export interface DataChannelEntryResponseType<T> {
createdAt: string;
updatedAt: string;
channelName: string;
subChannelName: string;
fromUserId: string;
createdBy: string;
entryId: string;
payloadJson: T;
pluginName: string;
toRoles: string[];
}

export interface UseDataChannelReturnType <T>{
export interface UseDataChannelReturnType<T> {
data: GraphqlResponseWrapper<DataChannelEntryResponseType<T>[]>,
pushEntry: PushEntryFunction<T>,
deleteEntry: DeleteEntryFunction,
Expand Down