feat(payment): PAYPAL-6035 skips the error when the strategy has already been deinitialized during braintree hosted filed error (#3064)

Author: bc-nick

packages/braintree-integration/src/braintree-credit-card/braintree-credit-card-payment-strategy.spec.ts

@@ -2,6 +2,8 @@ import { getScriptLoader } from '@bigcommerce/script-loader';
 import { merge } from 'lodash';
 
 import {
+    BraintreeError,
+    BraintreeErrorType,
     BraintreeFastlane,
     BraintreeIntegrationService,
     BraintreeScriptLoader,
@@ -527,6 +529,32 @@ describe('BraintreeCreditCardPaymentStrategy', () => {
                     payload.payment,
                 );
             });
+
+            it('throws an error if loadHostedFields finished with an error related to an invalid hosted field when the strategy is not deinitialized', async () => {
+                const braintreeError: BraintreeError = {
+                    code: 'HOSTED_FIELDS_INVALID_FIELD_SELECTOR',
+                    type: BraintreeErrorType.Merchant,
+                    name: 'BraintreeError',
+                    message: 'Selector does not reference a valid DOM node.',
+                };
+
+                jest.spyOn(braintreeScriptLoader, 'loadHostedFields').mockRejectedValue(
+                    braintreeError,
+                );
+                jest.spyOn(
+                    paymentIntegrationService.getState(),
+                    'isPaymentMethodInitialized',
+                ).mockReturnValue(true);
+
+                try {
+                    await braintreeCreditCardPaymentStrategy.initialize({
+                        methodId: paymentMethod.id,
+                        braintree: initializeOptions,
+                    });
+                } catch (error: Error | any) {
+                    expect(error.message).toEqual(braintreeError.message);
+                }
+            });
         });
     });
 });

packages/braintree-integration/src/braintree-credit-card/braintree-credit-card-payment-strategy.ts

@@ -85,7 +85,7 @@ export default class BraintreeCreditCardPaymentStrategy implements PaymentStrate
                 await this.initializeBraintreeFastlaneOrThrow(methodId);
             }
         } catch (error) {
-            return this.handleError(error);
+            return this.handleError(error, methodId);
         }
     }
 
@@ -135,8 +135,20 @@ export default class BraintreeCreditCardPaymentStrategy implements PaymentStrate
         return Promise.resolve();
     }
 
-    private handleError(error: unknown): never {
+    private handleError(error: unknown, methodId?: string): void {
         if (isBraintreeError(error)) {
+            const isPaymentMethodInitialized = !!(
+                methodId &&
+                this.paymentIntegrationService.getState().isPaymentMethodInitialized({ methodId })
+            );
+
+            if (
+                !isPaymentMethodInitialized &&
+                error.code === 'HOSTED_FIELDS_INVALID_FIELD_SELECTOR'
+            ) {
+                return;
+            }
+
             throw new PaymentMethodFailedError(error.message);
         }