fix(grit): fix queries for export { $foo } ... (#9586)

Author: dyc3

.changeset/fix-grit-export-named-from.md

@@ -0,0 +1,5 @@
+---
+"@biomejs/biome": patch
+---
+
+Fixed [#8828](https://github.com/biomejs/biome/issues/8828): Grit patterns using `export { $foo } from $source` now match named re-exports in JavaScript and TypeScript files.

crates/biome_grit_patterns/src/grit_target_language.rs

@@ -181,7 +181,9 @@ macro_rules! generate_target_language {
             fn is_metavariable(&self, node: &GritTargetNode) -> bool {
                 node.kind() == self.metavariable_kind()
                     || (self.is_alternative_metavariable_kind(node.kind())
-                        && self.exact_replaced_variable_regex().is_match(node.text()))
+                        && self
+                            .exact_replaced_variable_regex()
+                            .is_match(node.text().trim()))
             }
 
             fn align_padding<'a>(

crates/biome_grit_patterns/src/pattern_compiler/snippet_compiler.rs

@@ -972,4 +972,39 @@ mod tests {
         )
         "#);
     }
+
+    #[test]
+    fn test_export_named_from_snippet_node() {
+        let snippet = GritJsParser.parse_snippet("", "export { µfoo } from \"source\"", "");
+        let node = node_from_tree(&snippet).expect("no node found");
+        let formatted = format!("{node:#?}");
+
+        insta::assert_snapshot!(formatted, @r###"
+        GritTargetNode {
+            node: JsLanguage(
+                Node(
+                    0: JS_EXPORT@0..30
+                      0: JS_DECORATOR_LIST@0..0
+                      1: EXPORT_KW@0..7 "export" [] [Whitespace(" ")]
+                      2: JS_EXPORT_NAMED_FROM_CLAUSE@7..30
+                        0: (empty)
+                        1: L_CURLY@7..9 "{" [] [Whitespace(" ")]
+                        2: JS_EXPORT_NAMED_FROM_SPECIFIER_LIST@9..15
+                          0: JS_EXPORT_NAMED_FROM_SPECIFIER@9..15
+                            0: (empty)
+                            1: JS_METAVARIABLE@9..15
+                              0: GRIT_METAVARIABLE@9..15 "µfoo" [] [Whitespace(" ")]
+                            2: (empty)
+                        3: R_CURLY@15..17 "}" [] [Whitespace(" ")]
+                        4: FROM_KW@17..22 "from" [] [Whitespace(" ")]
+                        5: JS_MODULE_SOURCE@22..30
+                          0: JS_STRING_LITERAL@22..30 "\"source\"" [] []
+                        6: (empty)
+                        7: (empty)
+                    ,
+                ),
+            ),
+        }
+        "###);
+    }
 }

crates/biome_grit_patterns/tests/specs/ts/export_named_from_patterns.grit

@@ -0,0 +1 @@
+`export { $foo } from $source`

crates/biome_grit_patterns/tests/specs/ts/export_named_from_patterns.snap

@@ -0,0 +1,12 @@
+---
+source: crates/biome_grit_patterns/tests/spec_tests.rs
+expression: export_named_from_patterns
+---
+SnapshotResult {
+    messages: [],
+    matched_ranges: [
+        "2:1-2:39",
+    ],
+    rewritten_files: [],
+    created_files: [],
+}

crates/biome_grit_patterns/tests/specs/ts/export_named_from_patterns.ts

@@ -0,0 +1,2 @@
+// Named re-export
+export { foo } from "../../deep/path";

crates/biome_js_analyze/src/lint/nursery/no_redundant_default_export.rs

@@ -105,7 +105,7 @@ fn get_binding_from_identifier(
             .name()
             .ok()
             .and_then(|ref_id| model.binding(&ref_id)),
-        AnyIdentifier::JsLiteralExportName(_) => None,
+        AnyIdentifier::AnyJsLiteralExportName(_) => None,
     }
 }
 

crates/biome_js_factory/src/generated/node_factory.rs

@@ -11979,6 +11979,31 @@ impl IntoFormat<JsFormatContext> for biome_js_syntax::AnyJsInProperty {
         )
     }
 }
+impl AsFormat<JsFormatContext> for biome_js_syntax::AnyJsLiteralExportName {
+    type Format<'a> = FormatRefWithRule<
+        'a,
+        biome_js_syntax::AnyJsLiteralExportName,
+        crate::js::any::literal_export_name::FormatAnyJsLiteralExportName,
+    >;
+    fn format(&self) -> Self::Format<'_> {
+        FormatRefWithRule::new(
+            self,
+            crate::js::any::literal_export_name::FormatAnyJsLiteralExportName::default(),
+        )
+    }
+}
+impl IntoFormat<JsFormatContext> for biome_js_syntax::AnyJsLiteralExportName {
+    type Format = FormatOwnedWithRule<
+        biome_js_syntax::AnyJsLiteralExportName,
+        crate::js::any::literal_export_name::FormatAnyJsLiteralExportName,
+    >;
+    fn into_format(self) -> Self::Format {
+        FormatOwnedWithRule::new(
+            self,
+            crate::js::any::literal_export_name::FormatAnyJsLiteralExportName::default(),
+        )
+    }
+}
 impl AsFormat<JsFormatContext> for biome_js_syntax::AnyJsLiteralExpression {
     type Format<'a> = FormatRefWithRule<
         'a,