selftest: Split into .h and _impl.h

Author: real-or-random

Makefile.am

@@ -58,6 +58,7 @@ noinst_HEADERS += src/int128_struct_impl.h
 noinst_HEADERS += src/scratch.h
 noinst_HEADERS += src/scratch_impl.h
 noinst_HEADERS += src/selftest.h
+noinst_HEADERS += src/selftest_impl.h
 noinst_HEADERS += src/testrand.h
 noinst_HEADERS += src/testrand_impl.h
 noinst_HEADERS += src/hash.h

src/secp256k1.c

@@ -43,7 +43,7 @@
 #endif
 #include "scalar_impl.h"
 #include "scratch_impl.h"
-#include "selftest.h"
+#include "selftest_impl.h"
 
 #ifdef SECP256K1_NO_BUILD
 # error "secp256k1.h processed without SECP256K1_BUILD defined while building secp256k1.c"

src/selftest.h

@@ -7,27 +7,7 @@
 #ifndef SECP256K1_SELFTEST_H
 #define SECP256K1_SELFTEST_H
 
-#include "hash.h"
-#include "util.h"
-
-#include <string.h>
-
-static int secp256k1_selftest_sha256(void) {
-    static const char *input63 = "For this sample, this 63-byte string will be used as input data";
-    static const unsigned char output32[32] = {
-        0xf0, 0x8a, 0x78, 0xcb, 0xba, 0xee, 0x08, 0x2b, 0x05, 0x2a, 0xe0, 0x70, 0x8f, 0x32, 0xfa, 0x1e,
-        0x50, 0xc5, 0xc4, 0x21, 0xaa, 0x77, 0x2b, 0xa5, 0xdb, 0xb4, 0x06, 0xa2, 0xea, 0x6b, 0xe3, 0x42,
-    };
-    unsigned char out[32];
-    secp256k1_sha256 hasher;
-    secp256k1_sha256_initialize(&hasher);
-    secp256k1_sha256_write(&hasher, (const unsigned char*)input63, 63);
-    secp256k1_sha256_finalize(&hasher, out);
-    return secp256k1_memcmp_var(out, output32, 32) == 0;
-}
-
-static int secp256k1_selftest_passes(void) {
-    return secp256k1_selftest_sha256();
-}
+static int secp256k1_selftest_sha256(void);
+static int secp256k1_selftest_passes(void);
 
 #endif /* SECP256K1_SELFTEST_H */

src/selftest_impl.h

@@ -0,0 +1,34 @@
+/***********************************************************************
+ * Copyright (c) 2020 Pieter Wuille                                    *
+ * Distributed under the MIT software license, see the accompanying    *
+ * file COPYING or https://www.opensource.org/licenses/mit-license.php.*
+ ***********************************************************************/
+
+#ifndef SECP256K1_SELFTEST_IMPL_H
+#define SECP256K1_SELFTEST_IMPL_H
+
+#include "hash.h"
+#include "selftest.h"
+#include "util.h"
+
+#include <string.h>
+
+static int secp256k1_selftest_sha256(void) {
+    static const char *input63 = "For this sample, this 63-byte string will be used as input data";
+    static const unsigned char output32[32] = {
+        0xf0, 0x8a, 0x78, 0xcb, 0xba, 0xee, 0x08, 0x2b, 0x05, 0x2a, 0xe0, 0x70, 0x8f, 0x32, 0xfa, 0x1e,
+        0x50, 0xc5, 0xc4, 0x21, 0xaa, 0x77, 0x2b, 0xa5, 0xdb, 0xb4, 0x06, 0xa2, 0xea, 0x6b, 0xe3, 0x42,
+    };
+    unsigned char out[32];
+    secp256k1_sha256 hasher;
+    secp256k1_sha256_initialize(&hasher);
+    secp256k1_sha256_write(&hasher, (const unsigned char*)input63, 63);
+    secp256k1_sha256_finalize(&hasher, out);
+    return secp256k1_memcmp_var(out, output32, 32) == 0;
+}
+
+static int secp256k1_selftest_passes(void) {
+    return secp256k1_selftest_sha256();
+}
+
+#endif /* SECP256K1_SELFTEST_IMPL_H */