Replace validationError with alerts

Remove the inline validationError state and its on-screen text. Introduce showUpdateFailedAlert and an alert UI for update failures, and wire error paths to present this alert (while keeping the existing invalid-URL alert). Update error handling in save/update/clear flows to set the new alert flag instead of storing validationError.

Author: praveenperera

android/app/src/main/java/org/bitcoinppl/cove/flows/SettingsFlow/BlockExplorerSettingsScreen.kt

@@ -52,9 +52,11 @@ import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.launch
 import kotlinx.coroutines.withContext
 import org.bitcoinppl.cove.R
+import org.bitcoinppl.cove.TaggedItem
 import org.bitcoinppl.cove.views.MaterialDivider
 import org.bitcoinppl.cove.views.MaterialSection
 import org.bitcoinppl.cove.views.SectionHeader
+import org.bitcoinppl.cove_core.AppAlertState
 import org.bitcoinppl.cove_core.BlockExplorerOption
 import org.bitcoinppl.cove_core.Database
 import org.bitcoinppl.cove_core.allBlockExplorerOptions
@@ -71,6 +73,10 @@ fun BlockExplorerSettingsScreen(
     val snackbarHostState = remember { SnackbarHostState() }
     val keyboardController = LocalSoftwareKeyboardController.current
     val savedMessage = stringResource(R.string.block_explorer_saved)
+    val invalidUrlTitle = stringResource(R.string.block_explorer_invalid_url_title)
+    val invalidUrlMessage = stringResource(R.string.block_explorer_invalid_url_message)
+    val updateFailedTitle = stringResource(R.string.block_explorer_update_failed_title)
+    val updateFailedMessage = stringResource(R.string.block_explorer_update_failed_message)
 
     // only Bitcoin explorer overrides are editable; other networks use built-in defaults
     val editableNetworks = remember { listOf(Network.BITCOIN) }
@@ -84,24 +90,33 @@ fun BlockExplorerSettingsScreen(
     var selectedOption by remember(selectedNetwork) {
         mutableStateOf(config.selectedBlockExplorerOption(selectedNetwork))
     }
-    var validationError by remember(selectedNetwork) { mutableStateOf<String?>(null) }
     var isSaving by remember(selectedNetwork) { mutableStateOf(false) }
     val blockExplorerOptions = remember { allBlockExplorerOptions() }
 
+    fun showAlert(
+        title: String,
+        message: String,
+    ) {
+        app.alertState =
+            TaggedItem(
+                AppAlertState.General(
+                    title = title,
+                    message = message,
+                ),
+            )
+    }
+
     fun reload() {
         input = config.customBlockExplorer(selectedNetwork) ?: ""
         preview = config.effectiveBlockExplorerPreview(selectedNetwork)
         selectedOption = config.selectedBlockExplorerOption(selectedNetwork)
-        validationError = null
     }
 
     fun updatePreview(value: String) {
         try {
             preview = config.previewCustomBlockExplorer(selectedNetwork, value)
-            validationError = null
-        } catch (error: Exception) {
+        } catch (e: Exception) {
             preview = ""
-            validationError = error.message ?: error.toString()
         }
     }
 
@@ -120,15 +135,14 @@ fun BlockExplorerSettingsScreen(
                 input = normalized ?: ""
                 preview = config.effectiveBlockExplorerPreview(networkToSave)
                 selectedOption = config.selectedBlockExplorerOption(networkToSave)
-                validationError = null
                 keyboardController?.hide()
                 isSaving = false
 
                 launch {
                     snackbarHostState.showSnackbar(savedMessage)
                 }
-            } catch (error: Exception) {
-                validationError = error.message ?: error.toString()
+            } catch (e: Exception) {
+                showAlert(invalidUrlTitle, invalidUrlMessage)
                 isSaving = false
             }
         }
@@ -139,18 +153,17 @@ fun BlockExplorerSettingsScreen(
             input = config.setBlockExplorerOption(selectedNetwork, option) ?: ""
             preview = config.effectiveBlockExplorerPreview(selectedNetwork)
             selectedOption = config.selectedBlockExplorerOption(selectedNetwork)
-            validationError = null
-        } catch (error: Exception) {
-            validationError = error.message ?: error.toString()
+        } catch (e: Exception) {
+            showAlert(updateFailedTitle, updateFailedMessage)
         }
     }
 
     fun reset() {
         try {
             config.clearCustomBlockExplorer(selectedNetwork)
             reload()
-        } catch (error: Exception) {
-            validationError = error.message ?: error.toString()
+        } catch (e: Exception) {
+            showAlert(updateFailedTitle, updateFailedMessage)
         }
     }
 
@@ -286,8 +299,6 @@ fun BlockExplorerSettingsScreen(
                                 ),
                             keyboardActions = KeyboardActions(onDone = { save() }),
                             singleLine = true,
-                            isError = validationError != null,
-                            supportingText = validationError?.let { error -> { Text(error) } },
                             modifier = Modifier.fillMaxWidth(),
                         )
 

android/app/src/main/res/values/strings.xml

@@ -34,6 +34,10 @@
     <string name="block_explorer_save">Save</string>
     <string name="block_explorer_saved">Block explorer saved successfully</string>
     <string name="block_explorer_reset">Reset to Default</string>
+    <string name="block_explorer_invalid_url_title">Invalid URL</string>
+    <string name="block_explorer_invalid_url_message">Enter a valid URL, IP address, or block explorer template.</string>
+    <string name="block_explorer_update_failed_title">Unable to Update Block Explorer</string>
+    <string name="block_explorer_update_failed_message">Try again later.</string>
     <string name="title_wallet_information">Wallet information</string>
     <string name="label_wallet_network">Network</string>
     <string name="label_wallet_birthday">Birthday</string>

ios/Cove/Flows/SettingsFlow/BlockExplorerSettingsView.swift

@@ -8,9 +8,9 @@ struct BlockExplorerSettingsView: View {
     @State private var input: String
     @State private var preview: String
     @State private var selectedOption: BlockExplorerOption
-    @State private var validationError: String?
     @State private var isSaving = false
     @State private var showInvalidUrlAlert = false
+    @State private var showUpdateFailedAlert = false
     @FocusState private var isInputFocused: Bool
 
     init() {
@@ -77,12 +77,6 @@ struct BlockExplorerSettingsView: View {
                         }
                         .onSubmit(save)
 
-                    if let validationError {
-                        Text(validationError)
-                            .font(.caption)
-                            .foregroundStyle(.red)
-                    }
-
                     Button("Save", action: save)
                         .disabled(isSaving || input == (config.customBlockExplorer(network: selectedNetwork) ?? ""))
 
@@ -100,6 +94,11 @@ struct BlockExplorerSettingsView: View {
         } message: {
             Text("Enter a valid URL, IP address, or block explorer template.")
         }
+        .alert("Unable to Update Block Explorer", isPresented: $showUpdateFailedAlert) {
+            Button("OK", role: .cancel) {}
+        } message: {
+            Text("Try again later.")
+        }
     }
 
     private func blockExplorerOptionRow(_ option: BlockExplorerOption) -> some View {
@@ -141,17 +140,15 @@ struct BlockExplorerSettingsView: View {
             input = normalized ?? ""
             preview = config.effectiveBlockExplorerPreview(network: selectedNetwork)
             selectedOption = config.selectedBlockExplorerOption(network: selectedNetwork)
-            validationError = nil
         } catch {
-            validationError = error.localizedDescription
+            showUpdateFailedAlert = true
         }
     }
 
     private func reload() {
         input = config.customBlockExplorer(network: selectedNetwork) ?? ""
         preview = config.effectiveBlockExplorerPreview(network: selectedNetwork)
         selectedOption = config.selectedBlockExplorerOption(network: selectedNetwork)
-        validationError = nil
     }
 
     private func updatePreview(for value: String) {
@@ -160,10 +157,8 @@ struct BlockExplorerSettingsView: View {
                 network: selectedNetwork,
                 input: value
             )
-            validationError = nil
         } catch {
             preview = ""
-            validationError = error.localizedDescription
         }
     }
 
@@ -184,7 +179,6 @@ struct BlockExplorerSettingsView: View {
             input = normalized ?? ""
             preview = config.effectiveBlockExplorerPreview(network: networkToSave)
             selectedOption = config.selectedBlockExplorerOption(network: networkToSave)
-            validationError = nil
 
             Task { @MainActor in
                 await dismissAllPopups()
@@ -194,7 +188,6 @@ struct BlockExplorerSettingsView: View {
                     .present()
             }
         } catch {
-            validationError = error.localizedDescription
             showInvalidUrlAlert = true
         }
 
@@ -206,7 +199,7 @@ struct BlockExplorerSettingsView: View {
             try config.clearCustomBlockExplorer(network: selectedNetwork)
             reload()
         } catch {
-            validationError = error.localizedDescription
+            showUpdateFailedAlert = true
         }
     }
 }