publish debug.objAbstractStart, even if in objectsExclude array

Author: bkdotcom

src/Debug/AbstractObject.php

@@ -77,7 +77,7 @@ public function getAbstraction($obj, $method = null, &$hist = array())
             ),
             'extends' => array(),
             'implements' => $reflector->getInterfaceNames(),
-            'isExcluded' => $hist && \in_array($className, $this->abstracter->getCfg('objectsExclude')),
+            'isExcluded' => \in_array($className, $this->abstracter->getCfg('objectsExclude')),
             'isRecursion' => \in_array($obj, $hist, true),
             'methods' => array(),   // if !collectMethods, may still get ['__toString']['returnValue']
             'phpDoc' => array(
@@ -97,12 +97,12 @@ public function getAbstraction($obj, $method = null, &$hist = array())
             'hist' => $hist,
         ));
         $keysTemp = \array_flip(array('collectPropertyValues','reflector','hist'));
-        if (\array_filter(array($abs['isRecursion'], $abs['isExcluded']))) {
+        if ($abs['isRecursion']) {
             return \array_diff_key($abs->getValues(), $keysTemp);
         }
         /*
             debug.objAbstractStart subscriber may
-            set isExcluded to true (but not to false)
+            set isExcluded
             set collectPropertyValues (boolean)
             set collectMethods (boolean)
             set stringified
@@ -167,7 +167,9 @@ private function getAbstractionDetails(Event $abs)
     public function onStart(Event $event)
     {
         $obj = $event->getSubject();
-        if ($obj instanceof \mysqli && ($obj->connect_errno || !$obj->stat)) {
+        if ($obj instanceof \DateTime || $obj instanceof \DateTimeImmutable) {
+            $event['stringified'] = $obj->format(\DateTime::ISO8601);
+        } elseif ($obj instanceof \mysqli && ($obj->connect_errno || !$obj->stat)) {
             // avoid "Property access is not allowed yet"
             $event['collectPropertyValues'] = false;
         }
@@ -183,9 +185,7 @@ public function onStart(Event $event)
     public function onEnd(Event $event)
     {
         $obj = $event->getSubject();
-        if ($obj instanceof \DateTime || $obj instanceof \DateTimeImmutable) {
-            $event['stringified'] = $obj->format(\DateTime::ISO8601);
-        } elseif ($obj instanceof \DOMNodeList) {
+        if ($obj instanceof \DOMNodeList) {
             // for reasons unknown, DOMNodeList's properties are invisible to reflection
             $event['properties']['length'] = \array_merge(static::$basePropInfo, array(
                 'type' => 'integer',

src/Debug/Output/HtmlObject.php

@@ -47,8 +47,9 @@ public function dump($abs)
                 .' <span class="t_recursion">*RECURSION*</span>';
         }
         if ($abs['isExcluded']) {
-            return $strClassName
-                .' <span class="excluded">(not inspected)</span>';
+            return $this->dumpToString($abs)
+                .$strClassName."\n"
+                .'<span class="excluded">(not inspected)</span>';
         }
         $html = $this->dumpToString($abs)
             .$strClassName."\n"

tests/TypeObjectTest.php

@@ -89,7 +89,8 @@ public function providerTestMethod()
                         $this->assertContains(implode("\n", array(
                             '<dt class="properties">properties <span class="text-muted">(via __debugInfo)</span></dt>',
                             '<dd class="magic info">This object has a <code>__get</code> method</dd>',
-                            '<dd class="property public"><span class="t_modifier_public">public</span> <span class="property-name">debug</span> <span class="t_operator">=</span> <span class="t_object" data-accessible="public"><span class="t_classname"><span class="namespace">bdk\</span>Debug</span> <span class="excluded">(not inspected)</span></span></dd>',
+                            '<dd class="property public"><span class="t_modifier_public">public</span> <span class="property-name">debug</span> <span class="t_operator">=</span> <span class="t_object" data-accessible="public"><span class="t_classname"><span class="namespace">bdk\</span>Debug</span>',
+                            '<span class="excluded">(not inspected)</span></span></dd>',
                             '<dd class="property public"><span class="t_modifier_public">public</span> <span class="property-name">instance</span> <span class="t_operator">=</span> <span class="t_object" data-accessible="private"><span class="t_classname"><span class="namespace">bdk\DebugTest\</span>Test</span> <span class="t_recursion">*RECURSION*</span></span></dd>',
                             '<dd class="property public"><span class="t_modifier_public">public</span> <span class="property-name" title="Public Property.">propPublic</span> <span class="t_operator">=</span> <span class="t_string">redefined in Test (public)</span></dd>',
                             '<dd class="property public"><span class="t_modifier_public">public</span> <span class="property-name">propStatic</span> <span class="t_operator">=</span> <span class="t_string">I\'m Static</span></dd>',