Skip to content

Commit 7363ed4

Browse files
committed
ci: Set CXXFLAGS in addition to CFLAGS
`setuptools` uses CFLAGS for both C and C++ builds, but CMake distinguishes between them, and only uses CXXFLAGS for C++ builds. Whenever we want to set flags that affect both C and C++ builds, ensure that we set both CFLAGS and CXXFLAGS. Signed-off-by: Matt Wozniski <[email protected]>
1 parent 2d04f82 commit 7363ed4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ helgrind: ## Run helgrind, with the correct configuration
102102
.PHONY: ccoverage
103103
ccoverage: ## Run the test suite, with C++ code coverage
104104
$(MAKE) clean
105-
CFLAGS="$(CFLAGS) -O0 -pg --coverage" $(MAKE) build
105+
CFLAGS="$(CFLAGS) -O0 -pg --coverage" CXXFLAGS="$(CXXFLAGS) -O0 -pg --coverage" $(MAKE) build
106106
$(MAKE) check
107107
gcov -i build/*/src/memray/_memray -i -d
108108
lcov --capture --directory . --output-file cppcoverage.lcov

0 commit comments

Comments
 (0)