WIP: Add small test for coverage

Author: joaomariolago

core/libs/commonwealth/src/commonwealth/mavlink_comm/tests/test_MavlinkComm.py

@@ -0,0 +1,56 @@
+import os
+from unittest.mock import patch
+
+import pytest
+
+from commonwealth.mavlink_comm.MavlinkComm import MavlinkMessenger
+
+
+class TestMavlinkMessenger:
+    """Test cases for MavlinkMessenger class."""
+
+    def test_init_default_values(self) -> None:
+        """Test initialization with default values."""
+        with patch.dict(os.environ, {"MAV_SYSTEM_ID": "1", "MAV_COMPONENT_ID_ONBOARD_COMPUTER4": "194"}):
+            messenger = MavlinkMessenger()
+            assert messenger.system_id == 1
+            assert messenger.component_id == 194
+            assert messenger.sequence == 0
+            assert messenger.m2r_address == "localhost:6040"
+
+    def test_set_system_id(self) -> None:
+        """Test setting system ID."""
+        messenger = MavlinkMessenger()
+        messenger.set_system_id(10)
+        assert messenger.system_id == 10
+
+    def test_set_component_id(self) -> None:
+        """Test setting component ID."""
+        messenger = MavlinkMessenger()
+        messenger.set_component_id(200)
+        assert messenger.component_id == 200
+
+    def test_set_sequence(self) -> None:
+        """Test setting sequence."""
+        messenger = MavlinkMessenger()
+        messenger.set_sequence(5)
+        assert messenger.sequence == 5
+
+    def test_set_m2r_address_valid(self) -> None:
+        """Test setting valid m2r address."""
+        messenger = MavlinkMessenger()
+        messenger.set_m2r_address("192.168.1.100:8080")
+        assert messenger.m2r_address == "192.168.1.100:8080"
+
+    def test_set_m2r_address_invalid(self) -> None:
+        """Test setting invalid m2r address."""
+        messenger = MavlinkMessenger()
+        with pytest.raises(
+            ValueError, match="Invalid address. Valid address should follow the format 'localhost:6040'."
+        ):
+            messenger.set_m2r_address("invalid_address")
+
+    def test_m2r_rest_url_property(self) -> None:
+        """Test m2r_rest_url property."""
+        messenger = MavlinkMessenger()
+        assert messenger.m2r_rest_url == "http://localhost:6040/mavlink"

core/services/ardupilot_manager/firmware/test_FirmwareUpload.py

@@ -0,0 +1,78 @@
+import asyncio
+import pathlib
+import subprocess
+from unittest.mock import AsyncMock, MagicMock, patch
+
+import pytest
+
+from exceptions import FirmwareUploadFail, InvalidUploadTool, UploadToolNotFound
+from firmware.FirmwareUpload import FirmwareUploader
+
+
+class TestFirmwareUploader:
+    """Test cases for FirmwareUploader class."""
+
+    def test_binary_name(self) -> None:
+        """Test that binary_name returns the correct name."""
+        assert FirmwareUploader.binary_name() == "ardupilot_fw_uploader.py"
+
+    @patch("shutil.which")
+    def test_init_binary_not_found(self, mock_which: MagicMock) -> None:
+        """Test that UploadToolNotFound is raised when binary is not found."""
+        mock_which.return_value = None
+        with pytest.raises(UploadToolNotFound, match="Uploader binary not found on system's PATH."):
+            FirmwareUploader()
+
+    @patch("shutil.which")
+    @patch("subprocess.check_output")
+    def test_init_binary_invalid(self, mock_check_output: MagicMock, mock_which: MagicMock) -> None:
+        """Test that InvalidUploadTool is raised when binary validation fails."""
+        mock_which.return_value = "/fake/path/ardupilot_fw_uploader.py"
+        mock_check_output.side_effect = subprocess.CalledProcessError(1, "test")
+
+        with pytest.raises(InvalidUploadTool):
+            FirmwareUploader()
+
+    @patch("shutil.which")
+    @patch("subprocess.check_output")
+    def test_init_success(self, mock_check_output: MagicMock, mock_which: MagicMock) -> None:
+        """Test successful initialization."""
+        mock_which.return_value = "/fake/path/ardupilot_fw_uploader.py"
+        mock_check_output.return_value = b"help output"
+
+        uploader = FirmwareUploader()
+        assert uploader.binary() == pathlib.Path("/fake/path/ardupilot_fw_uploader.py")
+
+    @patch("shutil.which")
+    @patch("subprocess.check_output")
+    def test_set_autopilot_port(self, mock_check_output: MagicMock, mock_which: MagicMock) -> None:
+        """Test setting autopilot port."""
+        mock_which.return_value = "/fake/path/ardupilot_fw_uploader.py"
+        mock_check_output.return_value = b"help output"
+
+        uploader = FirmwareUploader()
+        new_port = pathlib.Path("/dev/ttyUSB0")
+        uploader.set_autopilot_port(new_port)
+        assert uploader._autopilot_port == new_port
+
+    @patch("shutil.which")
+    @patch("subprocess.check_output")
+    def test_set_baudrate_bootloader(self, mock_check_output: MagicMock, mock_which: MagicMock) -> None:
+        """Test setting bootloader baudrate."""
+        mock_which.return_value = "/fake/path/ardupilot_fw_uploader.py"
+        mock_check_output.return_value = b"help output"
+
+        uploader = FirmwareUploader()
+        uploader.set_baudrate_bootloader(921600)
+        assert uploader._baudrate_bootloader == 921600
+
+    @patch("shutil.which")
+    @patch("subprocess.check_output")
+    def test_set_baudrate_flightstack(self, mock_check_output: MagicMock, mock_which: MagicMock) -> None:
+        """Test setting flightstack baudrate."""
+        mock_which.return_value = "/fake/path/ardupilot_fw_uploader.py"
+        mock_check_output.return_value = b"help output"
+
+        uploader = FirmwareUploader()
+        uploader.set_baudrate_flightstack(115200)
+        assert uploader._baudrate_flightstack == 115200