Skip to content

Conversation

@nicoschmdt
Copy link
Contributor

@nicoschmdt nicoschmdt commented Nov 3, 2025

fix: #2896

Summary by Sourcery

Automatically update the bootstrap version to match semver-stable BlueOS tags without forcing a page reload and make bootstrap reload behavior configurable.

Bug Fixes:

  • Ensure the bootstrap version is updated when switching to a stable BlueOS tag
  • Prevent unconditional page reload after setting the bootstrap version

Enhancements:

  • Add an optional reload parameter to setBootstrapVersion to control window reload
  • Introduce isStable helper to detect semver-compliant stable tags

@sourcery-ai
Copy link

sourcery-ai bot commented Nov 3, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Parameterize bootstrap update to avoid redundant reloads, auto-update bootstrap on stable version selection, and add stable-version detection.

Sequence diagram for stable version selection and bootstrap update

sequenceDiagram
  participant User
  participant VersionChooser
  participant Backend
  participant Browser

  User->>VersionChooser: Selects a version (setVersion)
  VersionChooser->>VersionChooser: Checks if tag is stable (isStable)
  alt Tag is stable
    VersionChooser->>Backend: POST /bootstrap/current (setBootstrapVersion, reload=false)
  end
  VersionChooser->>Backend: POST /version/current
  Backend-->>VersionChooser: Responds
  VersionChooser->>VersionChooser: Show success message
  VersionChooser->>Browser: Reload page (if reload=true in setBootstrapVersion)
Loading

Class diagram for updated VersionChooser methods

classDiagram
  class VersionChooser {
    +async setBootstrapVersion(version: string, reload = true)
    +async setVersion(args: string | string[])
    +isStable(tag: string): boolean
    +isBeingDeleted(image: Version)
    -updating_bootstrap: boolean
    -deleting: string
  }

  class VCU {
    +isSemVer(tag: string): boolean
  }

  VersionChooser --> VCU: uses
Loading

File-Level Changes

Change Details Files
Make bootstrap update reload behavior configurable
  • Added optional reload parameter to setBootstrapVersion (defaulting to true)
  • Conditionally wrapped window.location.reload in a reload check
core/frontend/src/components/version-chooser/VersionChooser.vue
Auto-update bootstrap when switching to stable versions
  • In setVersion, detect stable tags via isStable
  • Invoke setBootstrapVersion(tag, false) before posting new version for stable tags
core/frontend/src/components/version-chooser/VersionChooser.vue
Add isStable helper for semantic-version checks
  • Added isStable method verifying semver format and excluding 'beta' tags
core/frontend/src/components/version-chooser/VersionChooser.vue

Assessment against linked issues

Issue Objective Addressed Explanation
#2896 Automatically update bootstrap when switching to a stable BlueOS version.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

We should update bootstrap when doing stable BlueOS updates

1 participant