Remove ICU_LIBRARIES from linking

- Comments from Monero seem to indicate that these are necessary, otherwise linking errors will result
- Doesn't appear to be true, and compilation seems fine without them.
- We already weren't linking them in libwallet, and simplewallet runs fine
- Looks like on Windows there are some issues displaying non-english Locales, but relatively small problem compared to potential issues arising from use of unicode

Author: who-biz

CMakeLists.txt

@@ -833,11 +833,6 @@ include_directories(SYSTEM ${Boost_INCLUDE_DIRS})
 if(MINGW)
   set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -Wa,-mbig-obj")
   set(EXTRA_LIBRARIES mswsock;ws2_32;iphlpapi;crypt32;bcrypt)
-  if(DEPENDS)
-    set(ICU_LIBRARIES icuio icui18n icuuc icudata icutu iconv)
-  else()
-    set(ICU_LIBRARIES icuio icuin icuuc icudt icutu iconv)
-  endif()
 elseif(APPLE OR OPENBSD OR ANDROID)
   set(EXTRA_LIBRARIES "")
 elseif(FREEBSD)

contrib/depends/packages/icu4c.mk

@@ -11,7 +11,6 @@ packages += unwind
 packages += sodium
 endif
 ifeq ($(host_os),mingw32)
-packages += icu4c
 packages += sodium
 endif
 

contrib/depends/packages/packages.mk

@@ -54,7 +54,6 @@ target_link_libraries(simplewallet
     ${Boost_PROGRAM_OPTIONS_LIBRARY}
     ${Boost_FILESYSTEM_LIBRARY}
     ${Boost_LOCALE_LIBRARY}
-    ${ICU_LIBRARIES}
     ${Boost_THREAD_LIBRARY}
     ${CMAKE_THREAD_LIBS_INIT}
     ${GNU_READLINE_LIBRARY}