do not concat BUNDLE_ACTIVATOR

fixes a problem in Verifier.verifyActivator() ("The Bundle-Activator header only supports a single type. The following types were found") when the bnd instructions already define a Bundle-Activator but a processed jar also contributed a Bundle-Activator. Before this fix the Bundle-Activator header was concatenated to the existing Bundle-Activator header in bnd.bnd and thus contained multiple values (separated by comma). But for Bundle-Activator this does not make sense as it supports only a single value.

Added Constants.BUNDLE_HEADERS_SINGLE_VALUE for a list of other headers which should also not be concatenated

Signed-off-by: Christoph Rueger <[email protected]>

Author: chrisrueger

biz.aQute.bndlib.tests/test/test/BuilderTest.java

@@ -3091,6 +3091,86 @@ public void testFindActivator() throws Exception {
 		}
 	}
 
+	/**
+	 * Check that the defined activator is found, and not concatenated by the
+	 * Bundle-Activator annotation in TypeInVersionedPackage
+	 *
+	 * @throws Exception
+	 */
+	@Test
+	public void testBundleActivatorShouldNotBeConcatenated() throws Exception {
+		Builder bmaker = new Builder();
+		try {
+			bmaker.setProperty("Bundle-Activator", "test.activator.Activator");
+			bmaker.setProperty("build", "xyz"); // for @Version annotation
+			bmaker.setProperty("Private-Package", "test.*");
+			bmaker.setProperty("-bundleannotations",
+				"test.annotationheaders.attrs.std.activator.TypeInVersionedPackage");
+			// bmaker.setProperty("-dsannotations", "!*");
+			// bmaker.setProperty("-metatypeannotations", "!*");
+			bmaker.setClasspath(new File[] {
+				new File("bin_test")
+			});
+			bmaker.setProperty("-fixupmessages.export",
+				"The annotation aQute.bnd.annotation.Export applied to package test.versionpolicy.api is deprecated and will be removed in a future release. The org.osgi.annotation.bundle.Export should be used instead");
+			bmaker.setProperty("-fixupmessages.directive",
+				"Unknown directive foobar: in Export-Package, allowed directives are uses:,mandatory:,include:,exclude:,-import:, and 'x-*'");
+
+			Jar jar = bmaker.build();
+			report("testBundleActivatorShouldNotBeConcatenated", bmaker, jar);
+
+			Attributes main = jar.getManifest()
+				.getMainAttributes();
+			assertEquals("test.activator.Activator", main.getValue(Constants.BUNDLE_ACTIVATOR));
+			assertFalse(
+				bmaker
+					.check(
+						"The Bundle-Activator header only supports a single type. The following types were found: test.activator.Activator,test.annotationheaders.attrs.std.activator.TypeInVersionedPackage. This usually happens when a macro resolves to multiple types"));
+		} finally {
+			bmaker.close();
+		}
+	}
+
+	/**
+	 * Check that the Bundle-Activator annotation in TypeInVersionedPackage
+	 * defines the Bundle-Activator of our bundle.
+	 *
+	 * @throws Exception
+	 */
+	@Test
+	public void testBundleActivatorFromAnnotation() throws Exception {
+		Builder bmaker = new Builder();
+		try {
+			// bmaker.setProperty("Bundle-Activator",
+			// "test.activator.Activator");
+			bmaker.setProperty("build", "xyz"); // for @Version annotation
+			bmaker.setProperty("Private-Package", "test.*");
+			bmaker.setProperty("-bundleannotations",
+				"test.annotationheaders.attrs.std.activator.TypeInVersionedPackage,*");
+			bmaker.setClasspath(new File[] {
+				new File("bin_test")
+			});
+			bmaker.setProperty("-fixupmessages.export",
+				"The annotation aQute.bnd.annotation.Export applied to package test.versionpolicy.api is deprecated and will be removed in a future release. The org.osgi.annotation.bundle.Export should be used instead");
+			bmaker.setProperty("-fixupmessages.directive",
+				"Unknown directive foobar: in Export-Package, allowed directives are uses:,mandatory:,include:,exclude:,-import:, and 'x-*'");
+
+			Jar jar = bmaker.build();
+			// assertTrue(bmaker.check());
+			report("testBundleActivatorFromAnnotation", bmaker, jar);
+
+			Attributes main = jar.getManifest()
+				.getMainAttributes();
+			assertEquals("test.annotationheaders.attrs.std.activator.TypeInVersionedPackage",
+				main.getValue(Constants.BUNDLE_ACTIVATOR));
+
+			assertFalse(bmaker.check(
+				"The Bundle-Activator header only supports a single type*"));
+		} finally {
+			bmaker.close();
+		}
+	}
+
 	@Test
 	public void testImportVersionRange() throws Exception {
 		assertVersionEquals("[1.1,2.0)", "[1.1,2.0)");

biz.aQute.bndlib/src/aQute/bnd/osgi/AnnotationHeaders.java

@@ -1,6 +1,7 @@
 package aQute.bnd.osgi;
 
 import static aQute.bnd.exceptions.ConsumerWithException.asConsumer;
+import static aQute.bnd.osgi.Constants.BUNDLE_HEADERS_SINGLE_VALUE;
 import static java.util.Collections.emptySet;
 
 import java.io.Closeable;
@@ -1030,11 +1031,20 @@ private void add(Annotation annotation, String name, String value) throws IOExce
 	/*
 	 * This method is a pass thru for the properties of the analyzer. If we have
 	 * such a header, we get the analyzer header and concatenate our values
-	 * after removing dups.
+	 * after removing dups. But there are exceptions: Some headers (e.g.
+	 * Bundle-Activator) only allow a single value and for them concatenating to
+	 * the analyzer header does not make sense.
 	 */
 
 	public String getHeader(String name) {
 		String value = analyzer.getProperty(name);
+
+		// for some OSGi headers we do not want to concatenate to existing
+		// analyzer value (analyzer value wins)
+		if (value != null && BUNDLE_HEADERS_SINGLE_VALUE.contains(name)) {
+			return value;
+		}
+
 		if (headers.containsKey(name)) {
 			//
 			// Remove duplicates and sort

biz.aQute.bndlib/src/aQute/bnd/osgi/Constants.java

@@ -348,13 +348,21 @@ public interface Constants {
 
 	// Ignore bundle specific headers. These headers do not make a lot of sense
 	// to inherit
+	// (https://docs.osgi.org/specification/osgi.core/8.0.0/framework.lifecycle.html#i3293513)
 	Set<String>	BUNDLE_SPECIFIC_HEADERS						= Sets.of(INCLUDE_RESOURCE, INCLUDERESOURCE,
 		BUNDLE_ACTIVATOR, BUNDLE_CLASSPATH, BUNDLE_NAME, BUNDLE_NATIVECODE, BUNDLE_SYMBOLICNAME, IMPORT_PACKAGE,
 		EXPORT_PACKAGE, DYNAMICIMPORT_PACKAGE, FRAGMENT_HOST, REQUIRE_BUNDLE, PRIVATE_PACKAGE, PRIVATEPACKAGE,
 		INCLUDEPACKAGE, EXPORT_CONTENTS, TESTCASES, NOMANIFEST, WAB, WABLIB, REQUIRE_CAPABILITY, PROVIDE_CAPABILITY,
 		DSANNOTATIONS, SERVICE_COMPONENT, SIGNATURE_TEST, METATYPE_ANNOTATIONS, CDIANNOTATIONS, AUTOMATIC_MODULE_NAME,
 		EXPORT_APIGUARDIAN, DEFINE_CONTRACT);
 
+	/**
+	 * OSGi Bundle headers, which only allow a single value (i.e. not multiple
+	 * values concatenated by comma)
+	 */
+	Set<String>	BUNDLE_HEADERS_SINGLE_VALUE					= Sets.of(BUNDLE_ACTIVATOR, BUNDLE_ACTIVATIONPOLICY,
+		BUNDLE_SYMBOLICNAME, BUNDLE_VERSION, BUNDLE_MANIFESTVERSION);
+
 	char		DUPLICATE_MARKER							= '~';
 	String		INTERNAL_EXPORTED_DIRECTIVE					= "-internal-exported:";
 	String		INTERNAL_BUNDLESYMBOLICNAME_DIRECTIVE		= "-internal-bundlesymbolicname:";