qa: apply coding standard

Signed-off-by: Maximilian Bösing <[email protected]>

Author: boesing

phpcs.xml.dist

@@ -32,5 +32,7 @@
         <exclude name="SlevomatCodingStandard.Commenting.RequireOneLineDocComment.MultiLineDocComment"/>
         <!-- Can be removed with dropping support for PHP 7.4 -->
         <exclude name="SlevomatCodingStandard.ControlStructures.RequireNullCoalesceEqualOperator.RequiredNullCoalesceEqualOperator"/>
+        <!-- Static callables are deprecated as of PHP 8.2 -->
+        <exclude name="SlevomatCodingStandard.Functions.StaticClosure.ClosureNotStatic"/>
     </rule>
 </ruleset>

tests/GenericMapTest.php

@@ -1104,7 +1104,7 @@ public function testWillJoinValuesWithSeperator(): void
      */
     public function testWillExchangeKeys(array $initial, callable $keyGenerator, array $expected): void
     {
-        $map = new GenericMap($initial);
+        $map       = new GenericMap($initial);
         $exchanged = $map->keyExchange($keyGenerator);
         self::assertEquals($expected, $exchanged->toNativeArray());
     }

tests/GenericOrderedListTest.php

@@ -1322,7 +1322,7 @@ public function testForAllPromiseWillSuppressErrors(): void
     {
         $map = new GenericOrderedList(['bar']);
 
-        $callback = static function (): void {
+        $callback = function (): void {
             throw new RuntimeException();
         };
         $map->forAll($callback)->suppressErrors();
@@ -1334,15 +1334,15 @@ public function testForAllPromiseWillSuppressErrors(): void
     public function testForAllPromiseWillExecuteFinallyMethodBeforeThrowingException(): void
     {
         $callbackInvoked = false;
-        $callback        = static function () use (&$callbackInvoked): void {
+        $callback        = function () use (&$callbackInvoked): void {
             $callbackInvoked = true;
         };
 
         $map = new GenericOrderedList(['bar']);
 
         $runtimeExceptionCaught = false;
         try {
-            $map->forAll(static function (): void {
+            $map->forAll(function (): void {
                 throw new RuntimeException();
             })->finally($callback);
         } catch (RuntimeException $exception) {
@@ -1419,7 +1419,7 @@ public function testWillFindIndexOfFirstMatchingItem(): void
         ]);
 
         /** @psalm-suppress TypeDoesNotContainType Might be a psalm bug */
-        self::assertSame(1, $list->findFirstMatchingIndex(static fn (int $value) => $value % 10 === 0));
+        self::assertSame(1, $list->findFirstMatchingIndex(fn (int $value) => $value % 10 === 0));
     }
 
     public function testWillReturnNullWhenNoItemMatchesFilter(): void
@@ -1431,7 +1431,7 @@ public function testWillReturnNullWhenNoItemMatchesFilter(): void
             8,
         ]);
 
-        self::assertNull($list->findFirstMatchingIndex(static fn (int $value) => $value % 2 !== 0));
+        self::assertNull($list->findFirstMatchingIndex(fn (int $value) => $value % 2 !== 0));
     }
 
     public function testWillPrependValueToTheList(): void
@@ -1458,12 +1458,12 @@ public function testWillReduceOrderedList(): void
 
         self::assertSame(
             15,
-            $list->reduce(static fn (int $carry, int $value) => $value + $carry, 0),
+            $list->reduce(fn (int $carry, int $value) => $value + $carry, 0),
             'A sum of all values were expected.',
         );
         self::assertSame(
             120,
-            $list->reduce(static fn (int $carry, int $value) => $carry === 0 ? $value : $value * $carry, 0),
+            $list->reduce(fn (int $carry, int $value) => $carry === 0 ? $value : $value * $carry, 0),
             'Expected that all values are being multiplied with each other',
         );
     }