Skip to content

Commit ff16743

Browse files
committed
Merge remote-tracking branch 'origin/main' into matthew/boost-5243-derive-signature-type-from-selector
2 parents c464a39 + 6f21288 commit ff16743

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

.changeset/proud-pianos-pretend.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@boostxyz/sdk": minor
3+
---
4+
5+
add padding to 4-byte function selectors in signature

packages/sdk/src/Actions/EventAction.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ import {
2626
fromHex,
2727
isAddress,
2828
isAddressEqual,
29+
pad,
2930
toEventSelector,
3031
zeroAddress,
3132
zeroHash,
@@ -1536,33 +1537,38 @@ export function prepareEventActionPayload({
15361537
signatureType:
15371538
actionClaimant.signatureType ??
15381539
detectSignatureType(actionClaimant.signature),
1540+
signature: pad(actionClaimant.signature),
15391541
},
15401542
actionStepOne: {
15411543
..._toRawActionStep(actionStepOne),
15421544
signatureType:
15431545
actionStepOne.signatureType ??
15441546
detectSignatureType(actionStepOne.signature),
1547+
signature: pad(actionStepOne.signature),
15451548
actionType: actionStepOne.actionType || 0,
15461549
},
15471550
actionStepTwo: {
15481551
..._toRawActionStep(actionStepTwo),
15491552
signatureType:
15501553
actionStepTwo.signatureType ??
15511554
detectSignatureType(actionStepTwo.signature),
1555+
signature: pad(actionStepTwo.signature),
15521556
actionType: actionStepTwo.actionType || 0,
15531557
},
15541558
actionStepThree: {
15551559
..._toRawActionStep(actionStepThree),
15561560
signatureType:
15571561
actionStepThree.signatureType ??
15581562
detectSignatureType(actionStepThree.signature),
1563+
signature: pad(actionStepThree.signature),
15591564
actionType: actionStepThree.actionType || 0,
15601565
},
15611566
actionStepFour: {
15621567
..._toRawActionStep(actionStepFour),
15631568
signatureType:
15641569
actionStepFour.signatureType ??
15651570
detectSignatureType(actionStepFour.signature),
1571+
signature: pad(actionStepFour.signature),
15661572
actionType: actionStepFour.actionType || 0,
15671573
},
15681574
},

0 commit comments

Comments
 (0)