Skip to content

Commit cf91fe6

Browse files
committed
chore: remove explanatory comments in exportTransactions
1 parent 4380925 commit cf91fe6

1 file changed

Lines changed: 0 additions & 6 deletions

File tree

packages/main/src/backend/export/exportTransactions.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -106,15 +106,9 @@ export async function createTransactionsInExternalVendors(
106106
...baseEvent,
107107
}),
108108
);
109-
// Intentionally do not re-throw: each exporter's outcome is already
110-
// recorded via counters + events. Re-throwing would reject this promise
111-
// and, combined with Promise.all's fail-fast behavior, orphan other
112-
// still-running exporters and skip the summary/EXPORT_PROCESS_END emit.
113109
}
114110
});
115111

116-
// Use allSettled so a thrown error from an exporter (e.g. something outside
117-
// the try/catch above) cannot abort the other exporters or skip the summary.
118112
await Promise.allSettled(exportPromises);
119113

120114
const result = failedCount === 0 ? 'success' : successCount === 0 ? 'failed' : 'partial';

0 commit comments

Comments
 (0)