chore: Bump vitest and avoid synchronous node apis in e2e tests (#1683)

I figured the test output rendering was weird but I think that's just
vitest 4 🤷‍♂️

Author: lforst

e2e/helpers/provider-runtime.mjs

@@ -1,5 +1,5 @@
 import { initLogger, startSpan, withCurrent } from "braintrust";
-import { existsSync, readFileSync } from "node:fs";
+import { promises as fs } from "node:fs";
 import { createRequire } from "node:module";
 import path from "node:path";
 import { fileURLToPath } from "node:url";
@@ -83,11 +83,13 @@ export async function getInstalledPackageVersion(importMetaUrl, packageName) {
 
   while (true) {
     const manifestPath = path.join(currentDir, "package.json");
-    if (existsSync(manifestPath)) {
-      const manifest = JSON.parse(readFileSync(manifestPath, "utf8"));
+    try {
+      const manifest = JSON.parse(await fs.readFile(manifestPath, "utf8"));
       if (manifest && typeof manifest.version === "string") {
         return manifest.version;
       }
+    } catch {
+      // Keep walking upward until we find the package root.
     }
 
     const parentDir = path.dirname(currentDir);

e2e/helpers/scenario-installer.ts

@@ -1,4 +1,4 @@
-import { promises as fs, rmSync } from "node:fs";
+import { promises as fs } from "node:fs";
 import { spawn } from "node:child_process";
 import * as path from "node:path";
 import { fileURLToPath } from "node:url";
@@ -103,24 +103,29 @@ function registerCleanupHandlers() {
 
   cleanupRegistered = true;
 
-  const cleanupAll = () => {
+  const cleanupAll = async () => {
     for (const dir of cleanupDirs) {
       try {
-        rmSync(dir, { force: true, recursive: true });
+        await fs.rm(dir, { force: true, recursive: true });
       } catch {
         // Best-effort cleanup for ephemeral test directories.
       }
     }
+    cleanupDirs.clear();
   };
 
-  process.on("exit", cleanupAll);
+  process.on("beforeExit", () => {
+    void cleanupAll();
+  });
   process.on("SIGINT", () => {
-    cleanupAll();
-    process.exit(130);
+    void cleanupAll().finally(() => {
+      process.exit(130);
+    });
   });
   process.on("SIGTERM", () => {
-    cleanupAll();
-    process.exit(143);
+    void cleanupAll().finally(() => {
+      process.exit(143);
+    });
   });
 }
 

e2e/package.json

@@ -19,7 +19,7 @@
     "braintrust": "workspace:^",
     "tsx": "^4.21.0",
     "typescript": "5.4.4",
-    "vitest": "^4.1.0",
+    "vitest": "^4.1.2",
     "zod": "4.3.6"
   }
 }

e2e/scenarios/nextjs-instrumentation/scenario.ts

@@ -1,8 +1,8 @@
-import { spawn, spawnSync } from "node:child_process";
+import { spawn } from "node:child_process";
 import net from "node:net";
 import path from "node:path";
 import { fileURLToPath } from "node:url";
-import { runMain } from "../../helpers/scenario-runtime";
+import { runMain, runNodeSubprocess } from "../../helpers/scenario-runtime";
 
 const scenarioDir = path.dirname(fileURLToPath(import.meta.url));
 const nextBin = new URL("./node_modules/next/dist/bin/next", import.meta.url)
@@ -97,19 +97,13 @@ async function main() {
   const baseUrl = `http://127.0.0.1:${port}`;
   const env = withScenarioEnv(process.env);
 
-  const buildResult = spawnSync(process.execPath, [nextBin, "build"], {
+  await runNodeSubprocess({
+    args: [nextBin, "build"],
     cwd: scenarioDir,
-    stdio: "pipe",
     env,
-    encoding: "utf8",
+    timeoutMs: 180_000,
   });
 
-  if (buildResult.status !== 0) {
-    throw new Error(
-      `next build failed with exit code ${buildResult.status}\nSTDOUT:\n${buildResult.stdout}\nSTDERR:\n${buildResult.stderr}`,
-    );
-  }
-
   const server = spawn(
     process.execPath,
     [nextBin, "start", "--hostname", "127.0.0.1", "--port", String(port)],

e2e/scenarios/test-framework-evals-vitest/scenario.vitest-v3.ts

@@ -1,5 +1,5 @@
 import { createRequire } from "node:module";
-import { existsSync } from "node:fs";
+import { promises as fs } from "node:fs";
 import * as path from "node:path";
 import { resolveScenarioDir } from "../../helpers/scenario-harness";
 import {
@@ -12,22 +12,24 @@ const require = createRequire(import.meta.url);
 const scenarioDir = resolveScenarioDir(import.meta.url);
 
 // Resolve the vitest.mjs bin by finding the package root via the main entry.
-function findVitestBin(packageName: string): string {
+async function findVitestBin(packageName: string): Promise<string> {
   const entryPath = require.resolve(packageName);
   let dir = path.dirname(entryPath);
   while (dir !== path.dirname(dir)) {
     const candidate = path.join(dir, "vitest.mjs");
-    if (existsSync(candidate)) {
+    try {
+      await fs.access(candidate);
       return candidate;
+    } catch {
+      // Keep walking upward.
     }
     dir = path.dirname(dir);
   }
   throw new Error(`Could not find vitest.mjs for ${packageName}`);
 }
 
-const vitestCliPath = findVitestBin("vitest-v3");
-
 async function main() {
+  const vitestCliPath = await findVitestBin("vitest-v3");
   const testRunId = getTestRunId();
 
   await runNodeSubprocess({

e2e/scenarios/test-framework-evals-vitest/scenario.vitest-v4.ts

@@ -1,5 +1,5 @@
 import { createRequire } from "node:module";
-import { existsSync } from "node:fs";
+import { promises as fs } from "node:fs";
 import * as path from "node:path";
 import { resolveScenarioDir } from "../../helpers/scenario-harness";
 import {
@@ -12,22 +12,24 @@ const require = createRequire(import.meta.url);
 const scenarioDir = resolveScenarioDir(import.meta.url);
 
 // Resolve the vitest.mjs bin by finding the package root via the main entry.
-function findVitestBin(packageName: string): string {
+async function findVitestBin(packageName: string): Promise<string> {
   const entryPath = require.resolve(packageName);
   let dir = path.dirname(entryPath);
   while (dir !== path.dirname(dir)) {
     const candidate = path.join(dir, "vitest.mjs");
-    if (existsSync(candidate)) {
+    try {
+      await fs.access(candidate);
       return candidate;
+    } catch {
+      // Keep walking upward.
     }
     dir = path.dirname(dir);
   }
   throw new Error(`Could not find vitest.mjs for ${packageName}`);
 }
 
-const vitestCliPath = findVitestBin("vitest-v4");
-
 async function main() {
+  const vitestCliPath = await findVitestBin("vitest-v4");
   const testRunId = getTestRunId();
 
   await runNodeSubprocess({

e2e/scenarios/turbopack-auto-instrumentation/scenario.ts

@@ -1,7 +1,8 @@
-import { spawn, spawnSync } from "node:child_process";
+import { spawn } from "node:child_process";
 import http from "node:http";
 import path from "node:path";
 import { fileURLToPath } from "node:url";
+import { runMain, runNodeSubprocess } from "../../helpers/scenario-runtime";
 
 const scenarioDir = path.dirname(fileURLToPath(import.meta.url));
 const PORT = 3999;
@@ -11,28 +12,15 @@ const PORT = 3999;
 const nextBin = new URL("./node_modules/next/dist/bin/next", import.meta.url)
   .pathname;
 
-// Run Next.js build (Turbopack is the default bundler in Next.js 16)
-const buildResult = spawnSync(process.execPath, [nextBin, "build"], {
-  cwd: scenarioDir,
-  stdio: "inherit",
-  env: { ...process.env, NEXT_TELEMETRY_DISABLED: "1" },
-});
-
-if (buildResult.status !== 0) {
-  throw new Error(`next build failed with exit code ${buildResult.status}`);
+function withScenarioEnv(
+  env: NodeJS.ProcessEnv = process.env,
+): NodeJS.ProcessEnv {
+  return {
+    ...env,
+    NEXT_TELEMETRY_DISABLED: "1",
+  };
 }
 
-// Start the Next.js server
-const server = spawn(
-  process.execPath,
-  [nextBin, "start", "--port", String(PORT)],
-  {
-    cwd: scenarioDir,
-    stdio: "inherit",
-    env: { ...process.env, NEXT_TELEMETRY_DISABLED: "1" },
-  },
-);
-
 function httpGet(url: string): Promise<{ status: number; body: string }> {
   return new Promise((resolve, reject) => {
     http
@@ -60,8 +48,27 @@ async function waitForServer(timeoutMs = 30_000): Promise<void> {
 }
 
 // Top-level await is not supported in CJS output, so use an explicit async
-// function and propagate failures via process.exit.
+// function and run it through the shared scenario wrapper.
 async function main() {
+  const env = withScenarioEnv(process.env);
+  await runNodeSubprocess({
+    args: [nextBin, "build"],
+    cwd: scenarioDir,
+    env,
+    timeoutMs: 180_000,
+  });
+
+  // Start the Next.js server
+  const server = spawn(
+    process.execPath,
+    [nextBin, "start", "--port", String(PORT)],
+    {
+      cwd: scenarioDir,
+      stdio: "inherit",
+      env,
+    },
+  );
+
   try {
     await waitForServer();
 
@@ -82,7 +89,4 @@ async function main() {
   }
 }
 
-main().catch((err) => {
-  console.error(err);
-  process.exit(1);
-});
+runMain(main);

integrations/browser-js/package.json

@@ -31,7 +31,7 @@
     "braintrust": "workspace:*",
     "tsup": "^8.3.5",
     "typescript": "^5.3.3",
-    "vitest": "^4.1.0"
+    "vitest": "^4.1.2"
   },
   "peerDependencies": {
     "zod": "^3.25.34 || ^4.0"

integrations/langchain-js/package.json

@@ -34,7 +34,7 @@
     "tsup": "^8.3.5",
     "typedoc": "^0.25.13",
     "typescript": "^5.3.3",
-    "vitest": "^4.1.0",
+    "vitest": "^4.1.2",
     "zod": "^3.25.34",
     "zod-to-json-schema": "^3.22.5"
   },

integrations/openai-agents-js/package.json

@@ -31,7 +31,7 @@
     "tsx": "^4.21.0",
     "typedoc": "^0.25.13",
     "typescript": "^5.3.3",
-    "vitest": "^4.1.0",
+    "vitest": "^4.1.2",
     "zod": "^3.25.34"
   },
   "peerDependencies": {