Skip to content

Conversation

@Aarbel
Copy link

@Aarbel Aarbel commented Apr 23, 2023

No description provided.

@Aarbel Aarbel changed the title WIP working dockerfile fix(dockerfile): make dockerfile easy to use / edit code / run everywhere Apr 23, 2023
@Aarbel Aarbel marked this pull request as draft April 23, 2023 21:29
@Aarbel Aarbel changed the title fix(dockerfile): make dockerfile easy to use / edit code / run everywhere [WIP] fix(dockerfile): make dockerfile easy to use / edit code / run everywhere Apr 23, 2023
@bmblb
Copy link
Collaborator

bmblb commented May 12, 2023

Thanks for a PR. While it contains some good changes, there are some questionable, like locking to a platform and running under root user. I am not ready to thoroughly test these changes, so let's keep this PR here for a time being as it might be helpful to some

@knobel-dk
Copy link

knobel-dk commented Aug 1, 2023

@bmblb

There are a few problems and misconceptions here..

Google Chrome is only packaged for amd64 and unavailable for ARM (so the platform is already what you called "locked"). This repo should use Chromium.

After that, the right way to approach this is multiarch images:
https://github.com/AdamTylerLynch/puppeteer-multiarch

Which is already done for Chromium by linuxserver.io, which I believe has enough activity and commitment that they can relied on:
https://hub.docker.com/r/linuxserver/chromium

There are other ways to make x86 Docker images run on other architectures but it will be a mess to support and run slower for the consumers.

@bmblb bmblb mentioned this pull request Sep 18, 2023
@bmblb
Copy link
Collaborator

bmblb commented Sep 19, 2023

I took some code from this PR - namely platform specification and a listener - and made that a new PR with some other changes. Closing this PR in favor of #15

@bmblb bmblb closed this Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants