Removed LFDI case warning (#44)

joshvote · web-flow · commit a2fa5f631ca8 · 2025-12-12T17:25:11.000+11:00
diff --git a/src/cactus_client/check/end_device.py b/src/cactus_client/check/end_device.py
@@ -66,8 +66,6 @@ def check_end_device(
                 )
 
     # Check for more specifics
-    if edev.lFDI is not None and (edev.lFDI.upper() != edev.lFDI):
-        context.warnings.log_step_warning(step, f"Expected an uppercase LFDI - received {edev.lFDI}")
     if edev.sFDI != client_config.sfdi:
         context.warnings.log_step_warning(
             step,
diff --git a/tests/unit/cactus_client/check/test_end_device.py b/tests/unit/cactus_client/check/test_end_device.py
@@ -80,8 +80,8 @@
             456,
             789,
             True,
-            True,
-        ),  # Case mismatch
+            False,
+        ),  # Case mismatch on LFDI is OK
         (
             {"matches_client": False, "matches_pin": True},
             [

Original file line number	Diff line number	Diff line change
`@@ -66,8 +66,6 @@ def check_end_device(`
`66`	`66`	`)`
`67`	`67`
`68`	`68`	`# Check for more specifics`
`69`		`- if edev.lFDI is not None and (edev.lFDI.upper() != edev.lFDI):`
`70`		`- context.warnings.log_step_warning(step, f"Expected an uppercase LFDI - received {edev.lFDI}")`
`71`	`69`	`if edev.sFDI != client_config.sfdi:`
`72`	`70`	`context.warnings.log_step_warning(`
`73`	`71`	`step,`
Original file line number	Diff line number	Diff line change
`@@ -80,8 +80,8 @@`
`80`	`80`	`456,`
`81`	`81`	`789,`
`82`	`82`	`True,`
`83`		`- True,`
`84`		`- ), # Case mismatch`
	`83`	`+ False,`
	`84`	`+ ), # Case mismatch on LFDI is OK`
`85`	`85`	`(`
`86`	`86`	`{"matches_client": False, "matches_pin": True},`
`87`	`87`	`[`