build: Refactor Dockerfile and local-build script to use build arguments for base image and agent version #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
ARG_UBUNTU_BASE_IMAGE,ARG_UBUNTU_BASE_IMAGE_TAG,ARG_TARGETARCHandARG_VSTS_AGENT_VERSIONinstead of hardcoding them. Also passes all arguments to the build script todocker buildto enable passing additional arguments.The main idea is that this can allow building a matrix of image variants for different Ubuntu flavours and tags, as well as AzDO agent version and architectures using the same Dockerfile and the same build script.
UBUNTU_BASE_IMAGE=my-ubuntu-image \ UBUNTU_BASE_IMAGE_TAG=22.04 \ VSTS_AGENT_VERSION=4.252.0 \ ./local-build.sh \ -t example