Skip to content

Conversation

@hangy
Copy link
Contributor

@hangy hangy commented Mar 12, 2025

Introduces ARG_UBUNTU_BASE_IMAGE, ARG_UBUNTU_BASE_IMAGE_TAG , ARG_TARGETARCH and ARG_VSTS_AGENT_VERSION instead of hardcoding them. Also passes all arguments to the build script to docker build to enable passing additional arguments.

The main idea is that this can allow building a matrix of image variants for different Ubuntu flavours and tags, as well as AzDO agent version and architectures using the same Dockerfile and the same build script.

UBUNTU_BASE_IMAGE=my-ubuntu-image \
    UBUNTU_BASE_IMAGE_TAG=22.04 \
    VSTS_AGENT_VERSION=4.252.0 \
    ./local-build.sh \
    -t example

@btungut btungut merged commit 29a09ba into btungut:master Mar 24, 2025
1 check passed
@btungut
Copy link
Owner

btungut commented Mar 24, 2025

Dear @hangy ,
Thank you so much for your contribution! Your PR has been reviewed and successfully merged into the master branch.
Looking forward to many more contributions from you!

@hangy hangy deleted the feature/docker-build-args branch March 24, 2025 19:32
@hangy
Copy link
Contributor Author

hangy commented Mar 24, 2025

No, thank you for building this in the first place! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants