Merge pull request #142 from samsara-dev/danhansen/soft-fail-propagate-signal-terminations

fix(soft-fail): propagate signal terminations

Author: petetomasik

hooks/post-command

@@ -80,10 +80,10 @@ perform_save() {
         # shellcheck disable=SC2064 # we want the expansion to happen now
         trap "cleanup_compression_tempfile '${ACTUAL_PATH}'" TERM EXIT
 
-        compress "${CACHE_PATH}" "${ACTUAL_PATH}" || return 1
+        compress "${CACHE_PATH}" "${ACTUAL_PATH}" || return $?
         already_compressed='true' # avoid re-compressing the files
       fi
-      backend_exec save "${KEY}" "${ACTUAL_PATH}" || return 1
+      backend_exec save "${KEY}" "${ACTUAL_PATH}" || return $?
       lower_level_updated='true' # to force saving higher levels
     else
       echo "Cache of ${LEVEL} already exists, skipping"

hooks/pre-command

@@ -48,10 +48,10 @@ perform_restore() {
         # shellcheck disable=SC2064 # we want the expansion to happen now
         trap "cleanup_compression_tempfile '${TEMP_PATH}'" TERM  EXIT
 
-        backend_exec get "${KEY}" "${TEMP_PATH}" || return 1
-        decompress "${TEMP_PATH}" "${RESTORE_PATH}" || return 1
+        backend_exec get "${KEY}" "${TEMP_PATH}" || return $?
+        decompress "${TEMP_PATH}" "${RESTORE_PATH}" || return $?
       else
-        backend_exec get "${KEY}" "${RESTORE_PATH}" || return 1
+        backend_exec get "${KEY}" "${RESTORE_PATH}" || return $?
       fi
 
       exit 0

lib/shared.bash

@@ -85,7 +85,11 @@ soft_fail_exec() {
     local exit_code=$?
     set -e
 
-    if [ ${exit_code} -ne 0 ]; then
+    # Exit codes 128+N indicate the process was killed by signal N
+    # Always propagate signal terminations (SIGTERM, SIGKILL, SIGINT, etc.)
+    if [ ${exit_code} -ge 128 ]; then
+      exit ${exit_code}
+    elif [ ${exit_code} -ne 0 ]; then
       echo "--- ⚠️  Cache ${operation} operation failed, continuing build (soft-fail enabled)"
       exit 0
     fi

tests/soft-fail.bats

@@ -225,4 +225,38 @@ teardown() {
   assert_output --partial 'Cache save operation failed, continuing build (soft-fail enabled)'
 
   unstub dummy_compress_wrapper
+}
+
+# ============================================================================
+# SIGNAL PROPAGATION TESTS
+# ============================================================================
+
+@test "Soft-fail restore: signal termination (exit >= 128) is propagated" {
+  export BUILDKITE_PLUGIN_CACHE_RESTORE=step
+
+  stub cache_dummy \
+    'exists \* : exit 0' \
+    'get \* \* : exit 143'
+
+  run "$PWD/hooks/pre-command"
+
+  assert_equal "$status" 143
+  refute_output --partial 'Cache restore operation failed, continuing build (soft-fail enabled)'
+
+  unstub cache_dummy
+}
+
+@test "Soft-fail save: signal termination (exit >= 128) is propagated" {
+  export BUILDKITE_PLUGIN_CACHE_SAVE=step
+  export BUILDKITE_PLUGIN_CACHE_FORCE=true
+
+  stub cache_dummy \
+    'save \* \* : exit 143'
+
+  run "$PWD/hooks/post-command"
+
+  assert_equal "$status" 143
+  refute_output --partial 'Cache save operation failed, continuing build (soft-fail enabled)'
+
+  unstub cache_dummy
 }