From 6447ec11dca2e9ea32bcdf9cae8d4936a0074cca Mon Sep 17 00:00:00 2001 From: p0ny Date: Mon, 14 Jul 2025 16:36:17 +0800 Subject: [PATCH 1/8] fix: sql review --- .github/workflows/sql-review-action.yml | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/.github/workflows/sql-review-action.yml b/.github/workflows/sql-review-action.yml index dca1e43..faed5a7 100644 --- a/.github/workflows/sql-review-action.yml +++ b/.github/workflows/sql-review-action.yml @@ -7,6 +7,15 @@ on: paths: - "migrations-semver/*.sql" +env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # set GITHUB_TOKEN because the 'Check release' step needs it to comment the pull request with check results. + BYTEBASE_URL: https://demo.bytebase.com + BYTEBASE_SERVICE_ACCOUNT: api@service.bytebase.com + BYTEBASE_SERVICE_ACCOUNT_SECRET: ${{ secrets.BYTEBASE_SERVICE_ACCOUNT_SECRET }} + BYTEBASE_PROJECT: "projects/hr" + BYTEBASE_TARGETS: "instances/prod-sample-instance/databases/hr_prod" + FILE_PATTERN: "migrations-semver/*.sql" + jobs: check-release-on-prod: permissions: @@ -18,12 +27,5 @@ jobs: - name: Checkout uses: actions/checkout@v4 - name: Check release - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # set GITHUB_TOKEN because the 'Check release' step needs it to comment the pull request with check results. - BYTEBASE_URL: https://demo.bytebase.com - BYTEBASE_SERVICE_ACCOUNT: api@service.bytebase.com - BYTEBASE_PROJECT: "projects/hr" - BYTEBASE_TARGETS: "instances/prod-sample-instance/databases/hr_prod" - FILE_PATTERN: "migrations-semver/*.sql" run: | bytebase-action check --url=${{ env.BYTEBASE_URL }} --service-account=${{ env.BYTEBASE_SERVICE_ACCOUNT }} --service-account-secret=${{ secrets.BYTEBASE_SERVICE_ACCOUNT_SECRET }} --project=${{ env.BYTEBASE_PROJECT }} --targets=${{ env.BYTEBASE_TARGETS }} --file-pattern=${{ env.FILE_PATTERN }} From 4022fa97b2952ea1a941218b511a628b8f098cf6 Mon Sep 17 00:00:00 2001 From: p0ny Date: Mon, 14 Jul 2025 16:37:24 +0800 Subject: [PATCH 2/8] test --- migrations-semver/1.3.5_nickname.sql | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/migrations-semver/1.3.5_nickname.sql b/migrations-semver/1.3.5_nickname.sql index 1e8b31a..af171af 100644 --- a/migrations-semver/1.3.5_nickname.sql +++ b/migrations-semver/1.3.5_nickname.sql @@ -1 +1,3 @@ -ALTER TABLE IF EXISTS users ADD COLUMN IF NOT EXISTS nickname VARCHAR(255) NOT NULL DEFAULT ''; \ No newline at end of file +ALTER TABLE IF EXISTS users ADD COLUMN IF NOT EXISTS nickname VARCHAR(255) NOT NULL DEFAULT ''; + +INSERT INTO users VALUES (1); \ No newline at end of file From 8c151e2417850938c744fb8988f38442ae232dde Mon Sep 17 00:00:00 2001 From: p0ny Date: Mon, 14 Jul 2025 16:43:06 +0800 Subject: [PATCH 3/8] env --- .github/workflows/sql-review-action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sql-review-action.yml b/.github/workflows/sql-review-action.yml index faed5a7..f55094e 100644 --- a/.github/workflows/sql-review-action.yml +++ b/.github/workflows/sql-review-action.yml @@ -28,4 +28,4 @@ jobs: uses: actions/checkout@v4 - name: Check release run: | - bytebase-action check --url=${{ env.BYTEBASE_URL }} --service-account=${{ env.BYTEBASE_SERVICE_ACCOUNT }} --service-account-secret=${{ secrets.BYTEBASE_SERVICE_ACCOUNT_SECRET }} --project=${{ env.BYTEBASE_PROJECT }} --targets=${{ env.BYTEBASE_TARGETS }} --file-pattern=${{ env.FILE_PATTERN }} + bytebase-action check --url=${{ env.BYTEBASE_URL }} --service-account=${{ env.BYTEBASE_SERVICE_ACCOUNT }} --service-account-secret=${{ env.BYTEBASE_SERVICE_ACCOUNT_SECRET }} --project=${{ env.BYTEBASE_PROJECT }} --targets=${{ env.BYTEBASE_TARGETS }} --file-pattern=${{ env.FILE_PATTERN }} From 9d3a748899f5a562e39e019fba4588f3ed301b96 Mon Sep 17 00:00:00 2001 From: p0ny Date: Mon, 14 Jul 2025 16:48:18 +0800 Subject: [PATCH 4/8] print --- .github/workflows/sql-review-action.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/sql-review-action.yml b/.github/workflows/sql-review-action.yml index f55094e..d068eef 100644 --- a/.github/workflows/sql-review-action.yml +++ b/.github/workflows/sql-review-action.yml @@ -28,4 +28,6 @@ jobs: uses: actions/checkout@v4 - name: Check release run: | + echo ${{ secrets.BYTEBASE_SERVICE_ACCOUNT_SECRET }} + echo ${{ env.BYTEBASE_SERVICE_ACCOUNT_SECRET }} bytebase-action check --url=${{ env.BYTEBASE_URL }} --service-account=${{ env.BYTEBASE_SERVICE_ACCOUNT }} --service-account-secret=${{ env.BYTEBASE_SERVICE_ACCOUNT_SECRET }} --project=${{ env.BYTEBASE_PROJECT }} --targets=${{ env.BYTEBASE_TARGETS }} --file-pattern=${{ env.FILE_PATTERN }} From 74ce66d2c2836e0b47855f90594f8949acd113dc Mon Sep 17 00:00:00 2001 From: p0ny Date: Mon, 14 Jul 2025 16:50:25 +0800 Subject: [PATCH 5/8] s --- .github/workflows/sql-review-action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sql-review-action.yml b/.github/workflows/sql-review-action.yml index d068eef..f529d1b 100644 --- a/.github/workflows/sql-review-action.yml +++ b/.github/workflows/sql-review-action.yml @@ -11,7 +11,7 @@ env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # set GITHUB_TOKEN because the 'Check release' step needs it to comment the pull request with check results. BYTEBASE_URL: https://demo.bytebase.com BYTEBASE_SERVICE_ACCOUNT: api@service.bytebase.com - BYTEBASE_SERVICE_ACCOUNT_SECRET: ${{ secrets.BYTEBASE_SERVICE_ACCOUNT_SECRET }} + BYTEBASE_SERVICE_ACCOUNT_SECRET: "bbs_EDyd8zleJVBEZyw81kLL" BYTEBASE_PROJECT: "projects/hr" BYTEBASE_TARGETS: "instances/prod-sample-instance/databases/hr_prod" FILE_PATTERN: "migrations-semver/*.sql" From 4a8c3d5a98e54a14285401b42c86141c798c49d3 Mon Sep 17 00:00:00 2001 From: p0ny Date: Mon, 14 Jul 2025 16:53:06 +0800 Subject: [PATCH 6/8] t1 --- .github/workflows/sql-review-action.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/sql-review-action.yml b/.github/workflows/sql-review-action.yml index f529d1b..645b4b9 100644 --- a/.github/workflows/sql-review-action.yml +++ b/.github/workflows/sql-review-action.yml @@ -11,15 +11,13 @@ env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # set GITHUB_TOKEN because the 'Check release' step needs it to comment the pull request with check results. BYTEBASE_URL: https://demo.bytebase.com BYTEBASE_SERVICE_ACCOUNT: api@service.bytebase.com - BYTEBASE_SERVICE_ACCOUNT_SECRET: "bbs_EDyd8zleJVBEZyw81kLL" + BYTEBASE_SERVICE_ACCOUNT_SECRET: ${{ secrets.BYTEBASE_SERVICE_ACCOUNT_SECRET }} BYTEBASE_PROJECT: "projects/hr" BYTEBASE_TARGETS: "instances/prod-sample-instance/databases/hr_prod" FILE_PATTERN: "migrations-semver/*.sql" jobs: check-release-on-prod: - permissions: - pull-requests: write # write permission required to allow the action writes the check results to the comment. runs-on: ubuntu-latest # use self-hosted machines if your Bytebase runs in internal networks. container: image: docker://bytebase/bytebase-action:latest From cd1cf7b12b7225cf338788f0f4af84b30b93c9bd Mon Sep 17 00:00:00 2001 From: p0ny Date: Mon, 14 Jul 2025 16:57:46 +0800 Subject: [PATCH 7/8] t2 --- .github/workflows/sql-review-action.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/sql-review-action.yml b/.github/workflows/sql-review-action.yml index 645b4b9..419682c 100644 --- a/.github/workflows/sql-review-action.yml +++ b/.github/workflows/sql-review-action.yml @@ -1,6 +1,7 @@ name: SQL review on pull request using bytebase-action image on: + push: pull_request: branches: - main From ebc89eabc92bc00e2677e53c40b4f6527abd9b41 Mon Sep 17 00:00:00 2001 From: p0ny Date: Mon, 14 Jul 2025 16:58:59 +0800 Subject: [PATCH 8/8] t2 --- .github/workflows/sql-review-action.yml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/.github/workflows/sql-review-action.yml b/.github/workflows/sql-review-action.yml index 419682c..f77f3f8 100644 --- a/.github/workflows/sql-review-action.yml +++ b/.github/workflows/sql-review-action.yml @@ -2,11 +2,6 @@ name: SQL review on pull request using bytebase-action image on: push: - pull_request: - branches: - - main - paths: - - "migrations-semver/*.sql" env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # set GITHUB_TOKEN because the 'Check release' step needs it to comment the pull request with check results.