fix (#485)

Author: c-cube

containers-data.opam

@@ -12,7 +12,7 @@ depends: [
   "dune" {>= "3.0"}
   "ocaml" {>= "4.08"}
   "containers" {= version}
-  "qcheck-core" {>= "0.18" & with-test}
+  "qcheck-core" {>= "0.91" & with-test}
   "iter" {with-test}
   "gen" {with-test}
   "mdx" {with-test}

containers.opam

@@ -14,7 +14,7 @@ depends: [
   "ocaml" {>= "4.08"}
   "either"
   "dune-configurator"
-  "qcheck-core" {>= "0.18" & with-test}
+  "qcheck-core" {>= "0.91" & with-test}
   "yojson" {with-test}
   "iter" {with-test}
   "gen" {with-test}

dune-project

@@ -30,7 +30,7 @@
   dune-configurator
   (qcheck-core
    (and
-    (>= 0.18)
+    (>= 0.91)
     :with-test))
   (yojson :with-test)
   (iter :with-test)
@@ -52,7 +52,7 @@
    (= :version))
   (qcheck-core
    (and
-    (>= 0.18)
+    (>= 0.91)
     :with-test))
   (iter :with-test)
   (gen :with-test)

tests/core/t_IO.ml

@@ -15,7 +15,7 @@ true
 ;;
 
 q
-  Q.(list_of_size Gen.(0 -- 40) printable_string)
+  Q.(list_size Gen.(0 -- 40) string_printable)
   (fun l ->
     let l' = ref [] in
     File.with_temp ~prefix:"test_containers" ~suffix:"" (fun name ->
@@ -27,7 +27,7 @@ q
 ;;
 
 q
-  Q.(list_of_size Gen.(0 -- 40) printable_string)
+  Q.(list_size Gen.(0 -- 40) string_printable)
   (fun l ->
     let l' = ref [] in
     File.with_temp ~prefix:"test_containers" ~suffix:"" (fun name ->
@@ -39,7 +39,7 @@ q
 ;;
 
 q
-  Q.(list_of_size Gen.(0 -- 40) printable_string)
+  Q.(list_size Gen.(0 -- 40) string_printable)
   (fun l ->
     let s = ref "" in
     File.with_temp ~prefix:"test_containers1" ~suffix:"" (fun name1 ->

tests/core/t_array.ml

@@ -108,7 +108,7 @@ eq ~cmp:( = )
 ;;
 
 q
-  Q.(array_of_size Gen.(0 -- 30) printable_string)
+  Q.(array_size Gen.(0 -- 30) string_printable)
   (fun a ->
     let b = sort_indices String.compare a in
     sorted String.compare a = Array.map (Array.get a) b)
@@ -127,18 +127,18 @@ eq ~cmp:( = )
 ;;
 
 q
-  Q.(array_of_size Gen.(0 -- 50) printable_string)
+  Q.(array_size Gen.(0 -- 50) string_printable)
   (fun a ->
     let b = sort_ranking String.compare a in
     let a_sorted = sorted String.compare a in
     a = Array.map (Array.get a_sorted) b)
 ;;
 
-q Q.(array small_int) (fun a -> rev (rev a) = a);;
+q Q.(array nat_small) (fun a -> rev (rev a) = a);;
 t @@ fun () -> rev [| 1; 2; 3 |] = [| 3; 2; 1 |];;
 t @@ fun () -> rev [| 1; 2 |] = [| 2; 1 |];;
 t @@ fun () -> rev [||] = [||];;
-q Q.(array small_int) (fun a -> mem 1 a = Array.mem 1 a);;
+q Q.(array nat_small) (fun a -> mem 1 a = Array.mem 1 a);;
 eq (Some 3) (max Stdlib.compare [| 1; 2; 3 |]);;
 eq (Some 4) (max Stdlib.compare [| 4; -1; 2; 3 |]);;
 eq None (max Stdlib.compare [||]);;
@@ -217,17 +217,17 @@ t @@ fun () -> 4 -- 1 |> Array.to_list = [ 4; 3; 2; 1 ];;
 t @@ fun () -> 0 -- 0 |> Array.to_list = [ 0 ];;
 
 q
-  Q.(pair small_int small_int)
+  Q.(pair nat_small nat_small)
   (fun (a, b) -> a -- b |> Array.to_list = CCList.(a -- b))
 ;;
 
 q
-  Q.(pair small_int small_int)
+  Q.(pair nat_small nat_small)
   (fun (a, b) -> a --^ b |> Array.to_list = CCList.(a --^ b))
 ;;
 
 q
-  Q.(pair (array small_int) (array small_int))
+  Q.(pair (array nat_small) (array nat_small))
   (fun (a, b) -> equal ( = ) a b = equal ( = ) b a)
 ;;
 
@@ -250,7 +250,7 @@ a = [| 3; 2; 1 |]
 ;;
 
 q
-  Q.(array_of_size Gen.(0 -- 100) small_int)
+  Q.(array_size Gen.(0 -- 100) nat_small)
   (fun a ->
     let b = Array.copy a in
     for i = 0 to Array.length a - 1 do
@@ -294,7 +294,7 @@ module IA = struct
   type t = int array
 end
 
-let gen_arr = Q.Gen.(array_size (1 -- 100) small_int)
+let gen_arr = Q.Gen.(array_size (1 -- 100) nat_small)
 
 let arr_arbitrary =
   Q.make

tests/core/t_bencode.ml

@@ -25,7 +25,7 @@ let g_rand_b =
     match n with
     | 0 -> oneof base
     | n ->
-      frequency
+      oneof_weighted
       @@ List.map (fun x -> 2, x) base
       @ [
           1, list_size (0 -- 10) (self (n - 1)) >|= B.list;

tests/core/t_byte_buffer.ml

@@ -59,7 +59,7 @@ let gen_op size : (_ * _) Gen.t =
     else
       []
   in
-  frequency
+  oneof_weighted
     (base
     @ [
         1, return (Get_contents, size);

tests/core/t_canonical_sexp.ml

@@ -28,7 +28,7 @@ let sexp_gen =
              match n with
              | 0 -> atom st
              | _ ->
-               frequency
+               oneof_weighted
                  [
                    1, atom; 2, map mklist (list_size (0 -- 10) (self (n / 10)));
                  ]

tests/core/t_cbor.ml

@@ -26,16 +26,16 @@ let gen_c : Cbor.t Q.Gen.t =
         let+ f = float in
         `Float f );
       ( 2,
-        let* n = frequency [ 20, 0 -- 150; 1, 151 -- 100_000 ] in
+        let* n = oneof_weighted [ 20, 0 -- 150; 1, 151 -- 100_000 ] in
         let+ s = string_size ~gen:printable (return n) in
         `Text s );
       ( 2,
-        let* n = frequency [ 20, 0 -- 150; 1, 151 -- 100_000 ] in
+        let* n = oneof_weighted [ 20, 0 -- 150; 1, 151 -- 100_000 ] in
         let+ s = string_size ~gen:char (return n) in
         `Bytes s );
     ]
   in
-  let g_base = frequency base in
+  let g_base = oneof_weighted base in
   let rec_ =
     [
       ( 2,
@@ -59,7 +59,7 @@ let gen_c : Cbor.t Q.Gen.t =
         `Tag (i, sub) );
     ]
   in
-  frequency
+  oneof_weighted
     (if size > 0 then
        base @ rec_
      else

tests/core/t_char.ml

@@ -4,12 +4,7 @@ include T;;
 
 eq (Some 'a') (of_int (to_int 'a'));;
 eq None (of_int 257);;
-
-q
-  (Q.string_of_size (Q.Gen.return 1))
-  (fun s -> Stdlib.( = ) (to_string s.[0]) s)
-;;
-
+q (Q.string_size (Q.Gen.return 1)) (fun s -> Stdlib.( = ) (to_string s.[0]) s);;
 q (Q.int_range 65 90 |> Q.map Char.chr) CCChar.is_uppercase_ascii;;
 
 q