performance improvements

[letmejustputthishere]

currently with complex projects it takes a couple of seconds until the extension is up to date.
e.g. when I type : Text to specify the type of a function argument, i can hover the text with my cursor and watch the progress of the tool with the info text updating like
unbound type T
unbound type Te
unbound type Tex

[letmejustputthishere]

can this be improved? i autosave every 500ms (in case that has an effect)

[rvanasa]

Does this still happen when autosave is turned off? This looks like a bug with the type checking debounce logic (rather than purely a performance issue), so it'll be helpful to know whether this is related to autosaving.

[AleDema]

I have this issue too and autosave is turned off, not sure if it could be caused by wsl2.

[letmejustputthishere]

turning off autosave didn't help :/
i'm on macos and use the latest version of the plugin

[rvanasa]

Thanks for checking. Are there any public projects which I could use to fully recreate the issue on my end?

For some context, large projects with > 100 files used to take over a minute to fully type-check (comparable to large Rust projects in VS Code). Something on the order of 1-2 seconds is currently expected for projects with large numbers of files and dependencies. This can be further improved in the future, and hopefully the recent round of optimizations makes the extension a lot more usable for large projects in the immediate term.

[letmejustputthishere]

Yes, you can check this
https://github.com/flowerpowerdao/power-equalizer

[rvanasa]

Thanks! I will increase the priority of further optimizations (currently representing DFINITY at ETHDenver, so I'll most likely take another look at this after March 5). If anyone reading this is at the convention, definitely come say hi! :)

[rvanasa]

Version 0.13.11 of the extension includes several bugfixes and improvements to address this issue. I'll leave this issue open for a bit; if you notice a difference (or lack thereof) in the smoothness of the type checker, definitely let me know so I can determine whether to prioritize another round of optimizations. :)

[marc0olo]

same observation on my side. I think the issue becomes even worse when opening a parent folder that includes many different projects. when I remember correctly I even saw an out of memory error message in the output

[ByronBecker]

Bumping this issue since @marc0olo mentioned it in the IC Developers OC channel - if there's a possible solution that scales well with the size of the project that would be very nice 🙂

I'd also be happy to give read access to our repo @rvanasa if you want to profile performance or test out various improvements

[walacemaia]

It seems to me that there is a memory leak, but I'm not sure if it's related to this extension. I use WSL2 in my environment and monitor the memory usage, which keeps increasing during development, forcing me to restart VS Code from time to time.