Make unsigned the default for int columns. #956
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markstory
reviewed
Nov 11, 2025
| * | ||
| * @return bool|null | ||
| */ | ||
| public function getUnsigned(): ?bool |
Member
There was a problem hiding this comment.
Why add these? they are on the parent class.
| $column = new Column(); | ||
| $column->setName('user_id')->setType('integer'); | ||
|
|
||
| $this->assertTrue($column->isUnsigned()); |
Member
There was a problem hiding this comment.
Changing this default will break existing applications. I'm also not convinced it is a sensible default.
Member
Author
There was a problem hiding this comment.
Before we go into details we should first assess, as outlined in the PR descr above, which strategy is best.
Currently its a bit messy, and we should move in one direction.
If unsigned by default is not sensible, maybe the default in general should be signed, including the primary keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC
Issue: cakephp/phinx#2267
Auto-generated primary keys default to unsigned, but manually added integer columns default to signed. This creates FK mismatches and requires explicit
'signed' => falsedeclarations.So we can either
Any takes?