Skip to content

use DEFAULT_OPTS in wait_for method #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

use DEFAULT_OPTS in wait_for method #1290

wants to merge 1 commit into from

Conversation

@irodkin
Copy link

@irodkin irodkin commented Apr 7, 2017

Like in calabash-android.

@calabash-ci
Copy link

calabash-ci commented Apr 7, 2017

Can one of the admins verify this patch?

duboviy
duboviy approved these changes Jul 15, 2017
View reviewed changes
Copy link
Contributor

@duboviy duboviy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@MortenGregersen MortenGregersen MortenGregersen approved these changes

@duboviy duboviy duboviy approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@irodkin @calabash-ci @MortenGregersen @duboviy