fix: uncommented TODO causing release build failures in RCTBottomAccessoryComponentView #469
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Bug fix - Fixed C++ compilation error caused by an uncommented TODO line in
RCTBottomAccessoryComponentView.mmthat was preventing release builds from succeeding. Preventing us to use renderBottomAccessoryView.How to test?
Build the iOS app in release mode
Verify the build completes successfully without compilation errors
Use the
renderBottomAccessoryViewprop onTabView:import { TabView } from 'react-native-bottom-tabs';
<TabView renderBottomAccessoryView={() => } />
Verify the bottom accessory view renders and layout events emit correctly
Screenshots
Note
Comments an unintended TODO in
RCTBottomAccessoryComponentView.mmthat broke release builds and updates Podfile.lock toreact-native-bottom-tabs1.0.2.packages/react-native-bottom-tabs/ios/RCTBottomAccessoryComponentView.mmto restore compilation;onNativeLayoutemission remains unchanged.apps/example/ios/Podfile.locktoreact-native-bottom-tabs1.0.2(andcommon), with related checksum changes.Written by Cursor Bugbot for commit 440b6ee. This will update automatically on new commits. Configure here.