Squashed commit of the following:

commit 27217585d7d4412eb7e30c8a3b8df843494f6bd7
Author: Kræn Hansen <[email protected]>
Date:   Tue May 6 17:04:37 2025 +0200

    Fix compilation warnings

Author: kraenhansen

packages/react-native-node-api-modules/cpp/CxxNodeApiHostModule.cpp

@@ -69,7 +69,7 @@ bool CxxNodeApiHostModule::loadNodeAddon(NodeAddon &addon,
     // the pointer address of the loaded module
     addon.generatedName.resize(32, '\0');
     snprintf(addon.generatedName.data(), addon.generatedName.size(),
-             "RN$NodeAddon_%lX", (uintptr_t)addon.moduleHandle);
+             "RN$NodeAddon_%p", addon.moduleHandle);
 
     initFn = LoaderPolicy::getSymbol(library, "napi_register_module_v1");
     if (NULL != initFn) {

packages/react-native-node-api-modules/package.json

@@ -17,7 +17,8 @@
   "scripts": {
     "build": "tsc --build",
     "copy-node-api-headers": "tsx scripts/copy-node-api-headers.ts",
-    "build-weak-node-api": "tsx scripts/build-weak-node-api.ts",
+    "generate-weak-node-api": "tsx scripts/generate-weak-node-api.ts",
+    "build-weak-node-api": "npm run generate-weak-node-api && react-native-node-api-cmake --android --apple --no-auto-link --no-weak-node-api-linkage --source ./weak-node-api",
     "test": "tsx --test src/node/**/*.test.ts src/node/*.test.ts"
   },
   "keywords": [

packages/react-native-node-api-modules/scripts/build-weak-node-api.ts renamed to packages/react-native-node-api-modules/scripts/generate-weak-node-api.ts

@@ -76,46 +76,56 @@ type FunctionDecl = {
   returnType: string;
   argumentTypes: string[];
   libraryPath: string;
+  fallbackReturnStatement: string;
 };
 
-export function generateNodeApiFunction({
+export function generateNodeApiFunctionStubBody({
   name,
   returnType,
   argumentTypes,
   libraryPath,
+  fallbackReturnStatement,
 }: FunctionDecl) {
-  const stubbedReturnStatement =
-    returnType === "void"
+  const returnStatement =
+    name === "napi_fatal_error"
       ? "abort();"
-      : "return napi_status::napi_generic_failure;";
+      : returnType === "void"
+      ? ""
+      : `return real_func(${argumentTypes
+          .map((t, index) => `arg${index}`)
+          .join(", ")}); // Call the real function`;
   return `
-typedef ${returnType} (*${name}_t)(${argumentTypes.join(", ")});
-
-${returnType} ${name}(${argumentTypes
-    .map((type, index) => `${type} arg${index}`)
-    .join(", ")})  {
-    #ifdef NODE_API_REEXPORT
     static ${name}_t real_func = NULL;
 
     if (!real_func) {
         void* handle = dlopen("${libraryPath}", RTLD_LAZY | RTLD_GLOBAL);
         if (!handle) {
             fprintf(stderr, "Failed to load ${libraryPath}: %s\\n", dlerror());
-            ${stubbedReturnStatement}
+            ${fallbackReturnStatement}
         }
 
         real_func = (${name}_t)dlsym(handle, "${name}");
         if (!real_func) {
             fprintf(stderr, "Failed to find symbol: %s\\n", dlerror());
-            ${stubbedReturnStatement}
+            ${fallbackReturnStatement}
         }
     }
 
-    ${returnType === "void" ? "" : "return "}real_func(${argumentTypes
-    .map((t, index) => `arg${index}`)
-    .join(", ")});  // Call the real function
+    ${returnStatement}
+  `;
+}
+
+export function generateNodeApiFunction(decl: FunctionDecl) {
+  const { name, returnType, argumentTypes, fallbackReturnStatement } = decl;
+  return `
+typedef ${returnType} (*${name}_t)(${argumentTypes.join(", ")});
+${returnType} ${name}(${argumentTypes
+    .map((type, index) => `${type} arg${index}`)
+    .join(", ")})  {
+    #ifdef NODE_API_REEXPORT
+    ${generateNodeApiFunctionStubBody(decl)}
     #else
-    ${stubbedReturnStatement}
+    ${fallbackReturnStatement}
     #endif
 }`;
 }
@@ -179,6 +189,10 @@ export function generateFakeNodeApiSource(version: NodeApiVersion) {
           libraryPath: engineSymbols.has(name)
             ? "libhermes.so"
             : "libnode-api-host.so",
+          fallbackReturnStatement:
+            returnType === "void"
+              ? "abort();"
+              : "return napi_status::napi_generic_failure;",
         })
       );
     }
@@ -201,21 +215,6 @@ async function run() {
     sourceCode,
     "utf-8"
   );
-  // Build for all supported platforms
-  cp.execFileSync(
-    "react-native-node-api-cmake",
-    [
-      "--android",
-      "--apple",
-      "--no-auto-link",
-      "--no-weak-node-api-linkage",
-      // TODO: Add support for passing variables through to CMake
-      // "-D NODE_API_REEXPORT=1",
-      "--source",
-      WEAK_NODE_API_PATH,
-    ],
-    { stdio: "inherit" }
-  );
 }
 
 run().catch((err) => {