Assert a symbolic link before dereferencingDirectory

Author: kraenhansen

packages/host/src/node/path-utils.test.ts

@@ -570,11 +570,19 @@ describe("dereferenceDirectory", () => {
         "file",
       );
 
+      {
+        // Verify that outer link is no longer a link
+        const stat = await fs.promises.lstat(symlinkPath);
+        assert(stat.isSymbolicLink());
+      }
+
       await dereferenceDirectory(symlinkPath);
 
-      // Verify that outer link is no longer a link
-      const symlinkStat = await fs.promises.lstat(symlinkPath);
-      assert(!symlinkStat.isSymbolicLink());
+      {
+        // Verify that outer link is no longer a link
+        const stat = await fs.promises.lstat(symlinkPath);
+        assert(!stat.isSymbolicLink());
+      }
 
       // Verify that the internal link is still a link to a readable file
       const internalLinkPath = path.join(symlinkPath, "linked-file.txt");

packages/host/src/node/path-utils.ts

@@ -546,6 +546,8 @@ export function findNodeAddonForBindings(id: string, fromDir: string) {
 
 export async function dereferenceDirectory(dirPath: string) {
   const tempPath = dirPath + ".tmp";
+  const stat = await fs.promises.lstat(dirPath);
+  assert(stat.isSymbolicLink(), `Expected a symbolic link at: ${dirPath}`);
   // Move the existing framework out of the way
   await fs.promises.rename(dirPath, tempPath);
   // Only dereference the symlink at tempPath (not recursively)