Skip to content

Commit 95d0daf

Browse files
committed
fix: Removed the async from tests
1 parent 6d9f26a commit 95d0daf

File tree

2 files changed

+41
-45
lines changed

2 files changed

+41
-45
lines changed
Lines changed: 39 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -1,52 +1,48 @@
11
/* eslint-disable @typescript-eslint/no-require-imports */
22
/* eslint-disable no-undef */
33
const assert = require("assert");
4+
const test_async = require("bindings")("addon.node");
45

5-
module.exports = async () => {
6-
const test_async = require("bindings")("addon.node");
7-
return new Promise((resolve, reject) => {
8-
const test = () =>
9-
new Promise((resolve, reject) => {
10-
test_async.Test(5, {}, (err, val) => {
11-
if (err) {
12-
reject(err);
13-
return;
14-
}
15-
try {
16-
assert.strictEqual(err, null);
17-
assert.strictEqual(val, 10);
18-
} catch (e) {
19-
reject(e);
20-
}
21-
resolve();
22-
});
23-
});
6+
const test = () =>
7+
new Promise((resolve, reject) => {
8+
test_async.Test(5, {}, (err, val) => {
9+
if (err) {
10+
reject(err);
11+
return;
12+
}
13+
try {
14+
assert.strictEqual(err, null);
15+
assert.strictEqual(val, 10);
16+
} catch (e) {
17+
reject(e);
18+
}
19+
resolve();
20+
});
21+
});
2422

25-
const testCancel = () =>
26-
new Promise((resolve) => {
27-
test_async.TestCancel(() => resolve());
28-
});
23+
const testCancel = () =>
24+
new Promise((resolve) => {
25+
test_async.TestCancel(() => resolve());
26+
});
2927

30-
const doRepeatedWork = (count = 0) =>
31-
new Promise((resolve, reject) => {
32-
const iterations = 100;
33-
const workDone = (status) => {
34-
try {
35-
assert.strictEqual(status, 0);
36-
} catch (e) {
37-
reject(e);
38-
}
39-
if (++count < iterations) {
40-
test_async.DoRepeatedWork(workDone);
41-
} else {
42-
resolve();
43-
}
44-
};
28+
const doRepeatedWork = (count = 0) =>
29+
new Promise((resolve, reject) => {
30+
const iterations = 100;
31+
const workDone = (status) => {
32+
try {
33+
assert.strictEqual(status, 0);
34+
} catch (e) {
35+
reject(e);
36+
}
37+
if (++count < iterations) {
4538
test_async.DoRepeatedWork(workDone);
46-
});
47-
48-
Promise.all([test(), testCancel(), doRepeatedWork()])
49-
.then(() => resolve())
50-
.catch(reject);
39+
} else {
40+
resolve();
41+
}
42+
};
43+
test_async.DoRepeatedWork(workDone);
5144
});
45+
46+
module.exports = () => {
47+
return Promise.all([test(), testCancel(), doRepeatedWork()]);
5248
};

packages/node-addon-examples/tests/buffers/addon.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
/* eslint-disable @typescript-eslint/no-require-imports */
22
/* eslint-disable no-undef */
33
const assert = require("assert");
4+
const addon = require("bindings")("addon.node");
45

56
const toLocaleString = (text) => {
67
return text
@@ -10,8 +11,7 @@ const toLocaleString = (text) => {
1011
.join("");
1112
};
1213

13-
module.exports = async () => {
14-
const addon = require("bindings")("addon.node");
14+
module.exports = () => {
1515
assert.strictEqual(toLocaleString(addon.newBuffer()), addon.theText);
1616
assert.strictEqual(toLocaleString(addon.newExternalBuffer()), addon.theText);
1717
assert.strictEqual(toLocaleString(addon.copyBuffer()), addon.theText);

0 commit comments

Comments
 (0)