fix: restore assert statements in tests + pulling device logs

Author: paradowstack

.github/workflows/check.yml

@@ -146,7 +146,18 @@ jobs:
             adb reverse tcp:8090 tcp:8090
             # Uninstall the app if already in the snapshot (unlikely but could result in a signature mismatch failure)
             adb uninstall com.microsoft.reacttestapp || true
+            # Start logcat in background and save logs
+            adb logcat > emulator-logcat.txt 2>&1 &
+            LOGCAT_PID=$!
             # Build, install and run the app
             npm run test:android -- --mode Release
             # Wait a bit for the sub-process to terminate, before terminating the emulator
             sleep 5
+            # Stop logcat
+            kill $LOGCAT_PID || true
+      - name: Upload device logs
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: emulator-logcat
+          path: apps/test-app/emulator-logcat.txt

packages/node-addon-examples/tests/buffers/addon.js

@@ -1,7 +1,7 @@
 /* eslint-disable @typescript-eslint/no-require-imports */
 /* eslint-disable no-undef */
+const assert = require("assert");
 const addon = require("bindings")("addon.node");
-// const assert = require("assert");
 
 const toLocaleString = (text) => {
   return text
@@ -11,16 +11,16 @@ const toLocaleString = (text) => {
     .join("");
 };
 
-// module.exports = async () => {
-console.log(toLocaleString(addon.newBuffer()), addon.theText);
-console.log(toLocaleString(addon.newExternalBuffer()), addon.theText);
-console.log(toLocaleString(addon.copyBuffer()), addon.theText);
-let buffer = addon.staticBuffer();
-console.log(addon.bufferHasInstance(buffer), true);
-console.log(addon.bufferInfo(buffer), true);
-addon.invalidObjectAsBuffer({});
+module.exports = () => {
+  assert.strictEqual(toLocaleString(addon.newBuffer()), addon.theText);
+  assert.strictEqual(toLocaleString(addon.newExternalBuffer()), addon.theText);
+  assert.strictEqual(toLocaleString(addon.copyBuffer()), addon.theText);
+  let buffer = addon.staticBuffer();
+  assert.strictEqual(addon.bufferHasInstance(buffer), true);
+  assert.strictEqual(addon.bufferInfo(buffer), true);
+  addon.invalidObjectAsBuffer({});
 
-// TODO: Add gc tests
-// @see
-// https://github.com/callstackincubator/react-native-node-api/issues/182
-// };
+  // TODO: Add gc tests
+  // @see
+  // https://github.com/callstackincubator/react-native-node-api/issues/182
+};