Merge branch 'main' of github.com:dougg0k/react-native-node-api into replace-package-manager

Author: dougg0k

.changeset/rich-donuts-mix.md

@@ -1,5 +1,5 @@
 ---
-"react-native-node-api-test-app": patch
+"@react-native-node-api/test-app": patch
 "react-native-node-api": patch
 ---
 

.github/workflows/check.yml

@@ -31,6 +31,7 @@ jobs:
           node-version: lts/jod
       - run: pnpm install --frozen-lockfile
       - run: pnpm lint
+      - run: pnpm prettier:check
   unit-tests:
     strategy:
       fail-fast: false

.prettierignore

@@ -0,0 +1,13 @@
+# Ignore artifacts
+dist
+build
+Pods
+target
+.cxx
+
+# Ignore hermes
+packages/host/hermes
+packages/node-addon-examples/examples
+packages/node-tests/node
+packages/node-tests/tests
+packages/node-tests/*.generated.js

apps/test-app/App.tsx

@@ -13,7 +13,7 @@ import { suites as nodeAddonExamplesSuites } from "@react-native-node-api/node-a
 function describeIf(
   condition: boolean,
   title: string,
-  fn: (this: Mocha.Suite) => void
+  fn: (this: Mocha.Suite) => void,
 ) {
   return condition ? describe(title, fn) : describe.skip(title, fn);
 }
@@ -31,7 +31,7 @@ function loadTests({
 }: Context) {
   describeIf(nodeAddonExamples, "Node Addon Examples", () => {
     for (const [suiteName, examples] of Object.entries(
-      nodeAddonExamplesSuites
+      nodeAddonExamplesSuites,
     )) {
       describe(suiteName, () => {
         for (const [exampleName, requireExample] of Object.entries(examples)) {

apps/test-app/babel.config.js

@@ -1,5 +1,5 @@
 module.exports = {
-  presets: ['module:@react-native/babel-preset'],
+  presets: ["module:@react-native/babel-preset"],
   // plugins: [['module:react-native-node-api/babel-plugin', { stripPathSuffix: true }]],
-  plugins: ['module:react-native-node-api/babel-plugin'],
+  plugins: ["module:react-native-node-api/babel-plugin"],
 };

apps/test-app/react-native.config.js

@@ -1,4 +1,3 @@
-
 const project = (() => {
   try {
     const { configureProjects } = require("react-native-test-app");
@@ -25,4 +24,4 @@ const project = (() => {
 
 module.exports = {
   ...(project ? { project } : undefined),
-};
+};

docs/HOW-IT-WORKS.md

@@ -25,7 +25,7 @@ The generated code looks something like this:
 
 ```javascript
 module.exports = require("react-native-node-api").requireNodeAddon(
-  "calculator-lib--prebuild"
+  "calculator-lib--prebuild",
 );
 ```
 

eslint.config.js

@@ -2,24 +2,27 @@
 
 import { globalIgnores } from "eslint/config";
 import globals from "globals";
-import eslint from '@eslint/js';
-import tseslint from 'typescript-eslint';
+import eslint from "@eslint/js";
+import tseslint from "typescript-eslint";
+import eslintConfigPrettier from "eslint-config-prettier/flat";
 
 export default tseslint.config(
-  globalIgnores([".nx/**"]),
-  globalIgnores(["**/dist/**"]),
-  globalIgnores(["apps/test-app/ios/**"]),
-  globalIgnores(["packages/host/hermes/**"]),
-  globalIgnores(["packages/node-addon-examples/examples/**"]),
-  globalIgnores(["packages/ferric-example/ferric_example.d.ts"]),
+  globalIgnores([
+    "**/dist/**",
+    "apps/test-app/ios/**",
+    "packages/host/hermes/**",
+    "packages/node-addon-examples/examples/**",
+    "packages/ferric-example/ferric_example.d.ts",
+  ]),
   eslint.configs.recommended,
   tseslint.configs.recommended,
+  eslintConfigPrettier,
   {
     files: [
       "apps/test-app/*.js",
       "packages/node-addon-examples/*.js",
       "packages/host/babel-plugin.js",
-      "packages/host/react-native.config.js"
+      "packages/host/react-native.config.js",
     ],
     languageOptions: {
       parserOptions: {
@@ -38,7 +41,7 @@ export default tseslint.config(
     files: [
       "packages/gyp-to-cmake/bin/*.js",
       "packages/host/bin/*.mjs",
-      "packages/host/scripts/*.mjs"
+      "packages/host/scripts/*.mjs",
     ],
     languageOptions: {
       globals: {

package.json

@@ -12,6 +12,8 @@
     "test": "pnpm --filter react-native-node-api --filter cmake-rn --filter gyp-to-cmake --filter node-addon-examples test",
     "bootstrap": "pnpm --recursive --if-present build",
     "prerelease": "pnpm --recursive --if-present prerelease",
+    "prettier:check": "prettier --experimental-cli --check .",
+    "prettier:write": "prettier --experimental-cli --write .",
     "release": "changeset publish"
   },
   "author": {
@@ -32,15 +34,18 @@
   "devDependencies": {
     "@changesets/cli": "^2.29.5",
     "@eslint/js": "^9.19.0",
+    "@prettier/plugin-oxc": "^0.0.4",
     "@reporters/github": "^1.7.2",
     "@tsconfig/node22": "^22.0.0",
     "@tsconfig/react-native": "3.0.5",
     "@types/node": "^22.13.0",
     "eslint": "^9.19.0",
+    "eslint-config-prettier": "^10.1.5",
     "globals": "^16.0.0",
+    "prettier": "^3.6.2",
     "react-native": "0.79.5",
+    "tsx": "^4.20.3",
     "typescript": "^5.7.3",
-    "typescript-eslint": "^8.22.0",
-    "tsx": "^4.19.3"
+    "typescript-eslint": "^8.22.0"
   }
 }

packages/cmake-rn/src/cli.ts

@@ -25,12 +25,12 @@ EventEmitter.defaultMaxListeners = 100;
 
 const verboseOption = new Option(
   "--verbose",
-  "Print more output during the build"
+  "Print more output during the build",
 ).default(process.env.CI === "true");
 
 const sourcePathOption = new Option(
   "--source <path>",
-  "Specify the source directory containing a CMakeLists.txt file"
+  "Specify the source directory containing a CMakeLists.txt file",
 ).default(process.cwd());
 
 // TODO: Add "MinSizeRel" and "RelWithDebInfo"
@@ -48,40 +48,40 @@ const defaultTargets = CMAKE_RN_TARGETS ? CMAKE_RN_TARGETS.split(",") : [];
 for (const target of defaultTargets) {
   assert(
     (allTargets as string[]).includes(target),
-    `Unexpected target in CMAKE_RN_TARGETS: ${target}`
+    `Unexpected target in CMAKE_RN_TARGETS: ${target}`,
   );
 }
 
 const targetOption = new Option("--target <target...>", "Targets to build for")
   .choices(allTargets)
   .default(
     defaultTargets,
-    "CMAKE_RN_TARGETS environment variable split by ','"
+    "CMAKE_RN_TARGETS environment variable split by ','",
   );
 
 const buildPathOption = new Option(
   "--build <path>",
-  "Specify the build directory to store the configured CMake project"
+  "Specify the build directory to store the configured CMake project",
 );
 
 const cleanOption = new Option(
   "--clean",
-  "Delete the build directory before configuring the project"
+  "Delete the build directory before configuring the project",
 );
 
 const outPathOption = new Option(
   "--out <path>",
-  "Specify the output directory to store the final build artifacts"
+  "Specify the output directory to store the final build artifacts",
 ).default(false, "./{build}/{configuration}");
 
 const noAutoLinkOption = new Option(
   "--no-auto-link",
-  "Don't mark the output as auto-linkable by react-native-node-api"
+  "Don't mark the output as auto-linkable by react-native-node-api",
 );
 
 const noWeakNodeApiLinkageOption = new Option(
   "--no-weak-node-api-linkage",
-  "Don't pass the path of the weak-node-api library from react-native-node-api"
+  "Don't pass the path of the weak-node-api library from react-native-node-api",
 );
 
 let program = new Command("cmake-rn")
@@ -99,7 +99,7 @@ let program = new Command("cmake-rn")
 for (const platform of platforms) {
   const allOption = new Option(
     `--${platform.id}`,
-    `Enable all ${platform.name} triplets`
+    `Enable all ${platform.name} triplets`,
   );
   program = program.addOption(allOption);
   program = platform.amendCommand(program);
@@ -133,13 +133,13 @@ program = program.action(
         }
         if (targets.size === 0) {
           throw new Error(
-            "Found no default targets: Install some platform specific build tools"
+            "Found no default targets: Install some platform specific build tools",
           );
         } else {
           console.error(
             chalk.yellowBright("ℹ"),
             "Using default targets",
-            chalk.dim("(" + [...targets].join(", ") + ")")
+            chalk.dim("(" + [...targets].join(", ") + ")"),
           );
         }
       }
@@ -162,20 +162,20 @@ program = program.action(
 
       // Configure every triplet project
       const targetsSummary = chalk.dim(
-        `(${getTargetsSummary(targetContexts)})`
+        `(${getTargetsSummary(targetContexts)})`,
       );
       await oraPromise(
         Promise.all(
           targetContexts.map(({ platform, ...context }) =>
-            configureProject(platform, context, baseOptions)
-          )
+            configureProject(platform, context, baseOptions),
+          ),
         ),
         {
           text: `Configuring projects ${targetsSummary}`,
           isSilent: baseOptions.verbose,
           successText: `Configured projects ${targetsSummary}`,
           failText: ({ message }) => `Failed to configure projects: ${message}`,
-        }
+        },
       );
 
       // Build every triplet project
@@ -189,20 +189,20 @@ program = program.action(
               force: true,
             });
             await buildProject(platform, context, baseOptions);
-          })
+          }),
         ),
         {
           text: "Building projects",
           isSilent: baseOptions.verbose,
           successText: "Built projects",
           failText: ({ message }) => `Failed to build projects: ${message}`,
-        }
+        },
       );
 
       // Perform post-build steps for each platform in sequence
       for (const platform of platforms) {
         const relevantTargets = targetContexts.filter(({ target }) =>
-          platformHasTarget(platform, target)
+          platformHasTarget(platform, target),
         );
         if (relevantTargets.length == 0) {
           continue;
@@ -212,7 +212,7 @@ program = program.action(
             outputPath: baseOptions.out || baseOptions.source,
             targets: relevantTargets,
           },
-          baseOptions
+          baseOptions,
         );
       }
     } catch (error) {
@@ -221,11 +221,11 @@ program = program.action(
       }
       throw error;
     }
-  }
+  },
 );
 
 function getTargetsSummary(
-  targetContexts: { target: string; platform: Platform }[]
+  targetContexts: { target: string; platform: Platform }[],
 ) {
   const targetsPerPlatform: Record<string, string[]> = {};
   for (const { target, platform } of targetContexts) {
@@ -257,7 +257,7 @@ function getTargetBuildPath(buildPath: string, target: unknown) {
 async function configureProject<T extends string>(
   platform: Platform<T[], Record<string, unknown>>,
   context: TargetContext<T>,
-  options: BaseOpts
+  options: BaseOpts,
 ) {
   const { target, buildPath, outputPath } = context;
   const { verbose, source, weakNodeApiLinkage } = options;
@@ -286,14 +286,14 @@ async function configureProject<T extends string>(
     {
       outputMode: verbose ? "inherit" : "buffered",
       outputPrefix: verbose ? chalk.dim(`[${target}] `) : undefined,
-    }
+    },
   );
 }
 
 async function buildProject<T extends string>(
   platform: Platform<T[], Record<string, unknown>>,
   context: TargetContext<T>,
-  options: BaseOpts
+  options: BaseOpts,
 ) {
   const { target, buildPath } = context;
   const { verbose, configuration } = options;
@@ -310,7 +310,7 @@ async function buildProject<T extends string>(
     {
       outputMode: verbose ? "inherit" : "buffered",
       outputPrefix: verbose ? chalk.dim(`[${target}] `) : undefined,
-    }
+    },
   );
 }