Add authctl user set-shell command

Author: adombeck

cmd/authctl/user/set-shell.go

@@ -0,0 +1,53 @@
+package user
+
+import (
+	"context"
+	"fmt"
+	"os"
+
+	"github.com/spf13/cobra"
+	"github.com/ubuntu/authd/cmd/authctl/internal/client"
+	"github.com/ubuntu/authd/cmd/authctl/internal/completion"
+	"github.com/ubuntu/authd/internal/proto/authd"
+)
+
+var setShellCmd = &cobra.Command{
+	Use:               "set-shell <name> <shell>",
+	Short:             "Set the login shell for a user",
+	Args:              cobra.ExactArgs(2),
+	ValidArgsFunction: setShellCompletionFunc,
+	RunE:              runSetShell,
+}
+
+func runSetShell(cmd *cobra.Command, args []string) error {
+	name := args[0]
+	shell := args[1]
+
+	svc, err := client.NewUserServiceClient()
+	if err != nil {
+		return err
+	}
+
+	resp, err := svc.SetShell(context.Background(), &authd.SetShellRequest{
+		Name:  name,
+		Shell: shell,
+	})
+	if err != nil {
+		return err
+	}
+
+	// Print any warnings returned by the server.
+	for _, warning := range resp.Warnings {
+		fmt.Fprintf(os.Stderr, "Warning: %s\n", warning)
+	}
+
+	return nil
+}
+
+func setShellCompletionFunc(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
+	if len(args) == 0 {
+		return completion.Users(cmd, args, toComplete)
+	}
+
+	return nil, cobra.ShellCompDirectiveNoFileComp
+}

cmd/authctl/user/set-shell_test.go

@@ -0,0 +1,62 @@
+package user_test
+
+import (
+	"os"
+	"os/exec"
+	"path/filepath"
+	"strings"
+	"testing"
+
+	"github.com/stretchr/testify/require"
+	"github.com/ubuntu/authd/internal/testutils"
+	"github.com/ubuntu/authd/internal/testutils/golden"
+	"google.golang.org/grpc/codes"
+)
+
+func TestSetShell(t *testing.T) {
+	t.Parallel()
+
+	daemonSocket := testutils.StartAuthd(t, daemonPath,
+		testutils.WithGroupFile(filepath.Join("testdata", "empty.group")),
+		testutils.WithPreviousDBState("one_user_and_group"),
+		testutils.WithCurrentUserAsRoot,
+	)
+
+	err := os.Setenv("AUTHD_SOCKET", daemonSocket)
+	require.NoError(t, err, "Failed to set AUTHD_SOCKET environment variable")
+
+	tests := map[string]struct {
+		args []string
+
+		expectedExitCode int
+	}{
+		"Set_shell_success": {args: []string{"set-shell", "user1", "/bin/bash"}, expectedExitCode: 0},
+
+		"Error_when_user_does_not_exist": {
+			args:             []string{"set-shell", "invaliduser", "/bin/bash"},
+			expectedExitCode: int(codes.NotFound),
+		},
+	}
+
+	for name, tc := range tests {
+		t.Run(name, func(t *testing.T) {
+			t.Parallel()
+
+			//nolint:gosec // G204 it's safe to use exec.Command with a variable here
+			cmd := exec.Command(authctlPath, append([]string{"user"}, tc.args...)...)
+			t.Logf("Running command: %s", strings.Join(cmd.Args, " "))
+			outputBytes, err := cmd.CombinedOutput()
+			output := string(outputBytes)
+			exitCode := cmd.ProcessState.ExitCode()
+
+			t.Logf("Command output:\n%s", output)
+
+			if tc.expectedExitCode == 0 {
+				require.NoError(t, err)
+			}
+			require.Equal(t, tc.expectedExitCode, exitCode, "Expected exit code does not match actual exit code")
+
+			golden.CheckOrUpdate(t, output)
+		})
+	}
+}

cmd/authctl/user/testdata/golden/TestSetShell/Error_when_user_does_not_exist

@@ -0,0 +1 @@
+Error: user "invaliduser" not found

cmd/authctl/user/testdata/golden/TestSetShell/Set_shell_success

@@ -6,6 +6,7 @@ Available Commands:
   lock        Lock (disable) a user managed by authd
   unlock      Unlock (enable) a user managed by authd
   set-uid     Set the UID of a user managed by authd
+  set-shell   Set the login shell for a user
 
 Flags:
   -h, --help   help for user

cmd/authctl/user/testdata/golden/TestUserCommand/Error_on_invalid_command

@@ -6,6 +6,7 @@ Available Commands:
   lock        Lock (disable) a user managed by authd
   unlock      Unlock (enable) a user managed by authd
   set-uid     Set the UID of a user managed by authd
+  set-shell   Set the login shell for a user
 
 Flags:
   -h, --help   help for user

cmd/authctl/user/testdata/golden/TestUserCommand/Error_on_invalid_flag

@@ -8,6 +8,7 @@ Available Commands:
   lock        Lock (disable) a user managed by authd
   unlock      Unlock (enable) a user managed by authd
   set-uid     Set the UID of a user managed by authd
+  set-shell   Set the login shell for a user
 
 Flags:
   -h, --help   help for user

cmd/authctl/user/testdata/golden/TestUserCommand/Help_flag

@@ -6,6 +6,7 @@ Available Commands:
   lock        Lock (disable) a user managed by authd
   unlock      Unlock (enable) a user managed by authd
   set-uid     Set the UID of a user managed by authd
+  set-shell   Set the login shell for a user
 
 Flags:
   -h, --help   help for user

cmd/authctl/user/testdata/golden/TestUserCommand/Usage_message_when_no_args

@@ -17,4 +17,5 @@ func init() {
 	UserCmd.AddCommand(lockCmd)
 	UserCmd.AddCommand(unlockCmd)
 	UserCmd.AddCommand(setUIDCmd)
+	UserCmd.AddCommand(setShellCmd)
 }