Basic section: Support logo block subtitles

[jmuzina]

Component/pattern to amend

Basic Section

Update the basic section's logo block item to support passing a subtitle (or some other name, up to decision by designers) that describes the logo block.

Visual

Context

This design includes a short title above a logo block in an area of content that could otherwise be achievable with a basic section pattern. However, the logo block does not expect or display any additional text above the logo block, and the basic section logo block design does not include it either.

This means that content like this must be displayed without using the basic section (as was done here), or a user could manually create it by using a "description" block for free HTML prior to a logo block.

If this is a recurring pattern, it seems to me that we should create a named parameter for this as part of the basic section logo block API.

If this sort of requirement could hold for all of the basic section blocks, we could also implement it at a higher, block-agnostic level (so that any block could include this subtitle).

[syncronize-issues-to-jira]

Thank you for reporting your feedback to us!

The internal ticket has been created: https://warthogs.atlassian.net/browse/WD-31821.

This message was autogenerated

[dgtlntv]

Design systems contribution meeting:

• We should have an optional title above the logo block (but it should not have a rule above it)

[devAyushDubey]

Hi @jmuzina,
This looks interesting to me. I would be happy to contribute.
I took a look at the codebase and at the partners/silicon refresher. I got a sense of the required enhancement in Basic Section template.
My plan is to add a conditional subtitle to the logo block inside basic section, something on the lines of:

...
 <div class="p-logo-section">
  {%- set subtitle = logo_block_config.get("subtitle", "") | trim -%}
  {%- if subtitle | length > 0 -%}
    <p class="p-heading--5">{{- subtitle -}}</p>
  {%- endif -%}
...

As mentioned by @dgtlntv, I won't be adding a rule over the text.

Please let me know if this approach sound good. If so, I would be happy to take this up.