Peer Review 2

[Lothengriol]

GEOS694 Final Project Peer Review Rubric

Instructions

• Remember this is just a class assignment, and your classmate's work. Please be respectful when providing feedback or comments.
• Open an issue in your classmate's GitHub repository and copy-paste this rubric.
• Go through the checklist, reflection questions and task below while consulting the repository.
• If any checklist items require more explanation or links to code blocks, include them.

Checklist

• Adheres to PEP-8 formatting (or consistent and explained when deviating)
  - Partially. array_figures.py, array_functions, and array_maps_pygmt.py do not follow PEP-8 formatting.

• Commit history that reflects small and frequent commits since project assignment

• Clear installation instructions, installation tested if available
  - Environment loads and files specified in the readme run. The output files do not all display at the same time, some only show up when earlier figure windows are closed out.

• Current version number (note the current version number)
  - Version 1.0.0

• Example problem with required data either provided or with a data fetching script

• Appropriate use of functions, tasks are broken into logical chunks

• Readability, organization, accessibility: Code is well-commented where necessary, files are organized in a logical manner, naming is intuitive or explanatory
  - Naming, commenting, organization, etc. are all good.

• Documentation is explanative of: what, why, how
  - The flowchart is very useful at conveying the process of inputs, executions, and outputs

• Task Number 1 Selected (note which task is selected)
  - Concurrency/Parallelization

• Task Number 2 Selected (note which task is selected)
  - Parameter Inputs

Reflection Questions

Please answer these questions based only on what you see in the GitHub repository, or what you can glean through opening issues.
Pretend you are an anonymous reviewer who has been asked to evaluate this repository for publication and open-access considerations.

1. What does this code do?
   - It makes a bunch of the figures on Cade's recent posters! More specifically it evaluates the performance of an Aleutian small-aperture seismic array and outputs these results as numerous figures.
2. How does this code do it?
   - It uses the parameters from the parameter file, then loads inventory, pulls regional earthquake event data, and processes their waveforms, saving the output to a CSV file and a handful of figures.
3. What data does this code work with?
   - Station waveforms for regional earthquakes, USGS event data, and calculated values (distance, arrival times, back-azimuths, etc.).
4. What do you find cool/interesting/unique about this code?
   - I find it cool how these plots recreate so much information Cade has compiled and calculated about these stations and events, and the presentation of that data is so neat and structured. The GitHub wiki for the repository is also a nice touch.
5. How can this code be improved (e.g., restructuring, optimization, improved examples, clearer explanation? - provide some input into how you could implement that)
   - More PEP-8 formatting would be good, as would reformatting the Repository Contents table to match the order the items appear (I'll do that last one in the Pull Request).

Task: Pull Request

Pull Request: #4