Add fallback check for directories created between calls

Author: dustinhuynh

classes/local/store/object_file_system.php

@@ -336,15 +336,11 @@ public function copy_object_from_external_to_local_by_hash($contenthash, $object
 
         if ($initiallocation === OBJECT_LOCATION_EXTERNAL) {
 
-            $localpath = $this->get_local_path_from_hash($contenthash);
             $localdirpath = $this->get_fulldir_from_hash($contenthash);
 
             // Folder may not exist yet if pulling a file that came from another environment.
-            if (!is_dir($localdirpath)) {
-                if (!mkdir($localdirpath, $this->dirpermissions, true)) {
-                    // Permission trouble.
-                    throw new file_exception('storedfilecannotcreatefiledirs');
-                }
+            if (!is_dir($localdirpath) && !mkdir($localdirpath, $this->dirpermissions, true) && !is_dir($localdirpath)) {
+                throw new \file_exception('storedfilecannotcreatefiledirs');
             }
 
             $success = $this->copy_from_external_to_local($contenthash);