fix: remove assembly name for PROVIDED_AL2 (#77)

When the Lambda runtime is set to `PROVIDE_AL2` the bundling will set
`/p:AssemblyName=bootstrap` to the `dotnet publish` command. However
when a project has project references, this condition will also apply to
the referenced projects resulting in an error `Ambiguous project name
'bootstrap'`.

This fix removes the automatic setting the assembly name. When using
this construct to deploy a custom runtime, make sure that the output
assembly name is `bootstrap` by either add it to the bundling options
`msbuildParameters: ['/p:AssemblyName=bootstrap']` or change the csproj
file to include `<AssemblyName>bootstrap</AssemblyName>`

Co-authored-by: Vincent Lesierse <[email protected]>

Author: vlesierse

README.md

@@ -45,6 +45,8 @@ new dotnet.DotNetFunction(this, 'MyFunction', {
 });
 ```
 
+Make sure `<AssemblyName>bootstrap</AssemblyName>` is set in the `csproj` file as this is required by the custom runtime. 
+
 > Publishing your application with Native AOT requires you to use the same processor architecture for the Lambda function as for your build environment. Without specification, the construct automatically selects the processor architecture of the machine where CDK is building your project.
 
 ## Community Extensions

src/private/bundling.ts

@@ -74,10 +74,7 @@ export class Bundling implements cdk.BundlingOptions {
 
     this.msbuildParameters = props.msbuildParameters ?? [];
     if (props.runtime.family === RuntimeFamily.OTHER) {
-      this.msbuildParameters.push(
-        '--self-contained',
-        '/p:AssemblyName=bootstrap',
-      );
+      this.msbuildParameters.push('--self-contained');
     }
 
     const environment = {

test/lambda-handler-aot/LambdaHandler.csproj

@@ -2,6 +2,7 @@
   <PropertyGroup>
     <TargetFramework>net7.0</TargetFramework>
     <OutputType>Exe</OutputType>
+    <AssemblyName>bootstrap</AssemblyName>
     <GenerateRuntimeConfigurationFiles>true</GenerateRuntimeConfigurationFiles>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>