Introduced fixed certificates for tests #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dw-kihara
commented
May 26, 2024
Comment on lines
+5
to
+6
| %% Update this when updating priv/cacerts.pem. | ||
| -define(NUM_OF_CERTS, 147). |
Author
There was a problem hiding this comment.
Initially, I thought this number could be generated by parsing priv/cacerts.pem.
However, I realized this approach would weaken the test because parsing the file to verify it is properly parsed sounds somewhat circular.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered the tests were failing because the tests check the contents of certificates, which changes frequently.
To address this, I introduced
cacerts_test_data/0which returns the fixed certificates for testing.Although
cacerts/0could return the fixed certificats during tests,I kept it to return the content of
priv/cacerts.pemto ensure it provides the correct certificates.I also modified
certifi_pt.erlto transform both functions and to make Dialyzer happy.