Skip to content

Reapply "CFE-4562: classfilterdata(): added docs for object of arrays/objects"#3488

Merged
nickanderson merged 2 commits into
cfengine:masterfrom
larsewi:revert-revert
Aug 25, 2025
Merged

Reapply "CFE-4562: classfilterdata(): added docs for object of arrays/objects"#3488
nickanderson merged 2 commits into
cfengine:masterfrom
larsewi:revert-revert

Conversation

@larsewi

@larsewi larsewi commented Aug 11, 2025

Copy link
Copy Markdown
Contributor

This commit broke docs because it depends on
cfengine/core#5850. Once the dependency is
merged, it should be safe to reapply this commit.

This reverts commit 3bc6348.

Ticket: CFE-4562
Signed-off-by: Lars Erik Wik lars.erik.wik@northern.tech

…/objects"

This commit broke docs because it depends on
cfengine/core#5850. Once the dependency is
merged, it should be safe to reapply this commit.

This reverts commit 3bc6348.

Ticket: CFE-4562
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
@larsewi

larsewi commented Aug 11, 2025

Copy link
Copy Markdown
Contributor Author

Please wait with merging this until dependency (cfengine/core#5850) is merged

@larsewi

larsewi commented Aug 19, 2025

Copy link
Copy Markdown
Contributor Author

@cf-bottom Jenkins please :)

@cf-bottom

Copy link
Copy Markdown

Comment thread content/reference/functions/classfilterdata.markdown Outdated
Comment thread content/reference/functions/classfilterdata.markdown Outdated
Comment thread content/reference/functions/classfilterdata.markdown Outdated
Comment thread content/reference/functions/classfilterdata.markdown Outdated
Comment thread content/reference/functions/classfilterdata.markdown Outdated
Comment thread content/reference/functions/classfilterdata.markdown Outdated
Comment thread content/reference/functions/classfilterdata.markdown Outdated
@larsewi

larsewi commented Aug 19, 2025

Copy link
Copy Markdown
Contributor Author

@cf-bottom Jenkins please :)

@cf-bottom

Copy link
Copy Markdown

@larsewi

larsewi commented Aug 19, 2025

Copy link
Copy Markdown
Contributor Author

^ Looks like the arguments did not automatically update. Is this cached somehow? 🤔

@larsewi larsewi requested a review from nickanderson August 19, 2025 14:16
@larsewi larsewi marked this pull request as ready for review August 19, 2025 14:16
@larsewi

larsewi commented Aug 25, 2025

Copy link
Copy Markdown
Contributor Author

Ping @nickanderson

@nickanderson

Copy link
Copy Markdown
Member

^ Looks like the arguments did not automatically update. Is this cached somehow? 🤔

I believe that comes from the syntax-description. So maybe the binary version generating the syntax didnt have your patch to evalfunction.c.

cf-promises --syntax-description=json | jq '.functions.classfilterdata'
{
  "cached": false,
  "category": "io",
  "collecting": true,
  "parameters": [
    {
      "description": "CFEngine variable identifier or inline JSON",
      "range": ".*",
      "type": "string"
    },
    {
      "description": "Specify type of data structure",
      "range": "array_of_arrays,array_of_objects,auto",
      "type": "option"
    },
    {
      "description": "Key or index of class expressions",
      "range": ".*",
      "type": "string"
    }
  ],
  "returnType": "data",
  "status": "normal",
  "variadic": false
}

@nickanderson nickanderson merged commit 3abfae6 into cfengine:master Aug 25, 2025
2 checks passed
@larsewi

larsewi commented Aug 26, 2025

Copy link
Copy Markdown
Contributor Author

I believe that comes from the syntax-description. So maybe the binary version generating the syntax didnt have your patch to evalfunction.c.

Probably! At least it looks correct on the website now.

@larsewi larsewi deleted the revert-revert branch April 27, 2026 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants