refactor: address review

Author: mempirate

msg-transport/Cargo.toml

@@ -17,8 +17,7 @@ async-trait.workspace = true
 futures.workspace = true
 tokio.workspace = true
 tracing.workspace = true
-
-thiserror = { workspace = true, optional = true }
+thiserror.workspace = true
 
 # QUIC
 quinn = { workspace = true, optional = true }
@@ -29,4 +28,4 @@ tracing-subscriber = "0.3"
 
 [features]
 default = []
-quic = ["dep:quinn", "dep:rcgen", "dep:thiserror"]
+quic = ["dep:quinn", "dep:rcgen"]

msg-transport/src/lib.rs

@@ -78,12 +78,17 @@ pub trait TransportExt<A: Address>: Transport<A> {
     }
 }
 
+/// An `await`-friendly interface for accepting inbound connections.
+///
+/// This struct is used to accept inbound connections from a transport. It is
+/// created using the [`TransportExt::accept`] method.
 pub struct Acceptor<'a, T, A>
 where
     T: Transport<A>,
     A: Address,
 {
     inner: &'a mut T,
+    /// The pending [`Transport::Accept`] future.
     pending: Option<T::Accept>,
     _marker: PhantomData<A>,
 }
@@ -109,6 +114,7 @@ where
         let this = self.get_mut();
 
         loop {
+            // If there's a pending accept future, poll it to completion
             if let Some(pending) = this.pending.as_mut() {
                 match pending.poll_unpin(cx) {
                     Poll::Ready(res) => {
@@ -119,6 +125,7 @@ where
                 }
             }
 
+            // Otherwise, poll the transport for a new accept future
             match Pin::new(&mut *this.inner).poll_accept(cx) {
                 Poll::Ready(accept) => {
                     this.pending = Some(accept);

msg-transport/src/quic/mod.rs

@@ -254,7 +254,7 @@ mod tests {
         let (tx, rx) = oneshot::channel();
 
         tokio::spawn(async move {
-            // tokio::time::sleep(Duration::from_secs(1)).await;
+            tokio::time::sleep(Duration::from_secs(1)).await;
 
             let mut stream = server.accept().await.unwrap();
 

msg-transport/src/quic/tls.rs

@@ -30,7 +30,7 @@ impl ServerCertVerifier for SkipServerVerification {
         _ocsp_response: &[u8],
         _now: rustls::pki_types::UnixTime,
     ) -> Result<rustls::client::danger::ServerCertVerified, rustls::Error> {
-        tracing::debug!(target = "quic.tls", "Skipping server verification");
+        tracing::debug!("skipping server verification");
         Ok(ServerCertVerified::assertion())
     }
 
@@ -40,7 +40,7 @@ impl ServerCertVerifier for SkipServerVerification {
         cert: &rustls::pki_types::CertificateDer<'_>,
         dss: &rustls::DigitallySignedStruct,
     ) -> Result<rustls::client::danger::HandshakeSignatureValid, rustls::Error> {
-        tracing::debug!(target = "quic.tls", "Verifying TLS 1.2 signature");
+        tracing::debug!("verifying TLS 1.2 signature");
         rustls::crypto::verify_tls12_signature(
             message,
             cert,
@@ -55,7 +55,7 @@ impl ServerCertVerifier for SkipServerVerification {
         cert: &rustls::pki_types::CertificateDer<'_>,
         dss: &rustls::DigitallySignedStruct,
     ) -> Result<rustls::client::danger::HandshakeSignatureValid, rustls::Error> {
-        tracing::debug!(target = "quic.tls", "Verifying TLS 1.3 signature");
+        tracing::debug!("verifying TLS 1.3 signature");
         rustls::crypto::verify_tls13_signature(
             message,
             cert,
@@ -65,11 +65,6 @@ impl ServerCertVerifier for SkipServerVerification {
     }
 
     fn supported_verify_schemes(&self) -> Vec<SignatureScheme> {
-        tracing::debug!(
-            target = "quic.tls",
-            "Supported verify schemes: {:?}",
-            self.0.signature_verification_algorithms.supported_schemes()
-        );
         self.0.signature_verification_algorithms.supported_schemes()
     }
 }