Skip to content

Add highlight for sidebar item matching route #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add highlight for sidebar item matching route #110

wants to merge 2 commits into from

Conversation

@petersonjean
Copy link

@petersonjean petersonjean commented Oct 22, 2019

No description provided.

@petersonjean petersonjean mentioned this pull request Oct 22, 2019
Open
@chamerling
Copy link
Owner

chamerling commented Oct 23, 2019

These changes will not be compliant with dark mode and are too complex. I suggest to have a look at https://github.com/chamerling/gitlab-teams/blob/master/src/App.vue#L118 and use the same.

@petersonjean
Copy link
Author

petersonjean commented Oct 23, 2019

I will update it accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@petersonjean @chamerling