Add config options to explicitly manage sca n or r results (#252)

* Add config options to explicitly manage sca n or r results

* Update readme with new config options

* Update tests to include new config options

* Change default return values for should auth on n and r to true

Author: Jemmings

docs/policy/sca.md

@@ -17,7 +17,9 @@ As with all configs, the standard wrapper is used.
     "shouldIdentify": true,             // Enable or disable identification step
     "shouldChallengeOptional": true,    // If challenge is optional from issuer, use this value to decide
     "shouldByPassChallenge": "",        // If challenge is required, override with this value (see below for options)
-    "shouldAuthOnError": true           // If the gateway authentication response is an error, authorize payment anyway
+    "shouldAuthOnError": true,          // If the gateway authentication response is an error, authorize payment anyway
+    "shouldAuthOnN": true,              // If the gateway authentication response is an N, authorize payment anyway
+    "shouldAuthOnR": true               // If the gateway authentication response is an R, authorize payment anyway
   }
 }
 ```

utils/generate.go

@@ -385,7 +385,7 @@ func buildSpec(conf Template) (object.Specification, error) {
 	case confPolMethodVerify:
 		return policy.MethodVerifyPolicy{Amount: 100, AmountCurrency: "GBP", ConnectorID: chg, VerifyMethodOnTokenization: new(bool)}, nil
 	case confPolSCA:
-		return policy.ScaPolicy{ShouldIdentify: new(bool), ShouldChallengeOptional: new(bool), ShouldByPassChallenge: "cascade", ShouldAuthOnError: new(bool), RequireSca: new(bool)}, nil
+		return policy.ScaPolicy{ShouldIdentify: new(bool), ShouldChallengeOptional: new(bool), ShouldByPassChallenge: "cascade", ShouldAuthOnError: new(bool), ShouldAuthOnN: new(bool), ShouldAuthOnR: new(bool), RequireSca: new(bool)}, nil
 	case confSchInitiator:
 		return scheduler.Initiator{Type: scheduler.InitiatorTypeAuth, InitialConnector: scheduler.ConnectorSelectorConfig, AttemptConfig: &scheduler.AttemptConfig{PoolType: scheduler.PoolTypeCascade, MethodSelector: scheduler.MethodSelectorPrimaryMethod, OverridePoolConnectorIDs: []string{}, CascadeDelay: new(time.Duration)}}, nil
 	case confSchOnDemand:

v1/policy/sca.go

@@ -54,6 +54,12 @@ type ScaPolicy struct {
 	// ShouldAuthOnError if true and an error response is returned from the connector; proceed to auth anyway
 	ShouldAuthOnError *bool `json:"shouldAuthOnError" yaml:"shouldAuthOnError" validate:"required"`
 
+	// ShouldAuthOnN if true and an "N" response is returned from the connector; proceed to auth anyway
+	ShouldAuthOnN *bool `json:"shouldAuthOnN" yaml:"shouldAuthOnN" validate:"required"`
+
+	// ShouldAuthOnR if true and an "R" response is returned from the connector; proceed to auth anyway
+	ShouldAuthOnR *bool `json:"shouldAuthOnR" yaml:"shouldAuthOnR" validate:"required"`
+
 	ChallengePreference ChallengePreference `json:"challengePreference" yaml:"challengePreference" validate:"omitempty,oneof=no-preference no-challenge request mandate"`
 }
 
@@ -85,6 +91,20 @@ func (s ScaPolicy) GetShouldAuthOnError() bool {
 	return *s.ShouldAuthOnError
 }
 
+func (s ScaPolicy) GetShouldAuthOnN() bool {
+	if s.ShouldAuthOnN == nil {
+		return true
+	}
+	return *s.ShouldAuthOnN
+}
+
+func (s ScaPolicy) GetShouldAuthOnR() bool {
+	if s.ShouldAuthOnR == nil {
+		return true
+	}
+	return *s.ShouldAuthOnR
+}
+
 // GetKind returns the ScaPolicy kind
 func (ScaPolicy) GetKind() object.Kind { return KindPolicySCA }