cleanup

Author: link2xt

src/smtp.rs

@@ -357,20 +357,17 @@ pub(crate) async fn smtp_send(
             warn!(context, "Unable to load SMTP job: {err:#}.");
             SendResult::Failure(err)
         }
-        Ok(()) => SendResult::Success,
-    };
-
-    if matches!(status, SendResult::Success) {
-        debug_assert!(smtp.connection.is_some());
-        if let Some(transport_id) = smtp.connection.as_ref().map(|conn| conn.transport_id)
-            && let Err(err) = record_success(context, transport_id).await
-        {
-            warn!(
-                context,
-                "Failed to record successful use of transport {transport_id} in smtp_success table: {err:#}."
-            );
+        Ok(()) => {
+            let transport_id = connection.transport_id;
+            if let Err(err) = record_success(context, transport_id).await {
+                warn!(
+                    context,
+                    "Failed to record successful use of transport {transport_id} in smtp_success table: {err:#}."
+                );
+            }
+            SendResult::Success
         }
-    }
+    };
 
     if let SendResult::Failure(err) = &status
         && let Some(msg_id) = msg_id