tests: test more reliably if port 25 is reachable - #580
Merged
Merged
Conversation
hpk42
approved these changes
Jun 3, 2025
Contributor
|
a bit unsure about the CI failures which are about "undeployed changes". |
Contributor
Author
hm, this test needs some more love I think... or it should fail with a |
missytake
force-pushed
the
dkim-tests-port-25
branch
from
June 12, 2025 13:57
95231fc to
12b2b57
Compare
missytake
force-pushed
the
dkim-tests-port-25
branch
from
June 29, 2025 16:11
12b2b57 to
0944920
Compare
Contributor
Author
the test regularly fails if there was a lint issue. I'm trying to tackle it in #592 |
Contributor
Author
|
Should be merged after #591 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for #552
The test failed with this error:
Port 25 is blocked on my network, it's not hard to see why it failed.
cmdeploy/src/cmdeploy/tests/online/test_0_login.py::test_no_vrfywas skipped correctly in the samecmdeploy testrun, so I took that method of testing whether port 25 is available, seems more reliable.