Skip to content

Conversation

@vincentzvo
Copy link

@vincentzvo vincentzvo commented Oct 3, 2025

Overview

  • This pull request introduces comprehensive data for Albanian addresses, expanding the faker-cxx library’s functionality to generate realistic location-based information for the sq_AL locale.

Changes Made

  • Added sq_AL Locale Data

  • Implemented new data structures for the Albanian locale within location_data.h.

Cities & States

  • Added an extensive list of Albanian cities (albaniaCities).

  • Added counties as administrative regions (albaniaStates).

Street Data

  • Introduced common Albanian street suffixes (albaniaStreetSuffixes) such as Rruga, Bulevardi, Sheshi, Rrugica, and Autostrada.

  • Defined albaniaStreetFormats to align with Albanian naming conventions.

Address Composition Rules

  • Defined albaniaAddressFormats to support both {street} {buildingNumber} and {buildingNumber} {street}.

  • Defined albaniaBuildingNumberFormats using 1–3 digit formats.

Zip Codes

  • Added Albanian postal code format (####).

Unit Tests

  • Registered sq_AL locale in location_test.cpp.

Added:

  • shouldGenerateAlbaniaStreet — validates generated street names include one of the Albanian street prefixes.

  • shouldGenerateAlbaniaAddress — validates generated street addresses contain an Albanian street prefix.

Why This Matters

  • This change enables developers to generate culturally realistic Albanian addresses, instead of generic placeholders. The addition of authentic street suffixes, city names, and address structures ensures data generated for Albania looks natural and representative of real-world usage.

All related tests are passing, including both general location tests and the new Albania-specific ones.

Resolves #448

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add location addresses data from Albania

1 participant