Fixes

Author: ppiwowa-csco

plugins/modules/cli_templates_info.py

@@ -126,8 +126,6 @@
   type: list
 """
 
-from typing import Literal
-
 from catalystwan.api.template_api import CLITemplate
 from catalystwan.api.templates.device_template.device_template import DeviceTemplate
 from catalystwan.models.templates import DeviceTemplateInformation

plugins/modules/policy.py

@@ -110,22 +110,22 @@
 from catalystwan.models.policy import (
     AnyPolicyDefinition,
     AnyPolicyList,
+    AnySecurityPolicyInfo,
     CentralizedPolicy,
     CentralizedPolicyInfo,
     LocalizedPolicy,
     LocalizedPolicyInfo,
     SecurityPolicy,
-    AnySecurityPolicyInfo,
 )
 from catalystwan.models.policy.centralized import CentralizedPolicyEditPayload
 from catalystwan.session import ManagerHTTPError
 from catalystwan.typed_list import DataSequence
 
 from ..module_utils.policy_templates.centralized import policy_centralized_definition
-from ..module_utils.policy_templates.security import policy_security_definition
 from ..module_utils.policy_templates.definition import policy_definition_definition, policy_definition_type_mapping
 from ..module_utils.policy_templates.list import policy_list_definition, policy_list_type_mapping
 from ..module_utils.policy_templates.localized import policy_localized_definition
+from ..module_utils.policy_templates.security import policy_security_definition
 from ..module_utils.result import ModuleResult
 from ..module_utils.vmanage_module import AnsibleCatalystwanModule
 
@@ -210,9 +210,9 @@ def run_module():
             object_endpoint = module.session.api.policy.security
             policy_definition = module.params.get("security")
 
-        all_policies: DataSequence[CentralizedPolicyInfo | LocalizedPolicyInfo | AnySecurityPolicyInfo] = (
-            module.get_response_safely(object_endpoint.get)
-        )
+        all_policies: DataSequence[
+            CentralizedPolicyInfo | LocalizedPolicyInfo | AnySecurityPolicyInfo
+        ] = module.get_response_safely(object_endpoint.get)
         if module.params.get("security"):
             all_policies = all_policies.security
         filtered_definitions: Optional[

roles/policies/defaults/main.yml

@@ -5,7 +5,7 @@
 
 policies: {}
 default_policy:
-  name: "Ansible Managed centralized policy"
+  name: "Ansible Managed policy"
   hub_and_spoke: []
   mesh: []
   acl_policy: []

roles/policies/tasks/example-forwarding-qos.yml

@@ -5,7 +5,7 @@
 # https://www.cisco.com/c/en/us/td/docs/routers/sdwan/configuration/qos/vEdge-20-x/qos-book/forwarding-qos.html#Cisco_Concept.dita_aa3e0d07-462e-463f-8f45-681f38f61ab0
 
 - name: Save list of QoS schedulers
-  set_fact:
+  ansible.builtin.set_fact:
     qos_schedulers:
       - name: VOICE
         queue: 0
@@ -60,7 +60,7 @@
   loop: "{{ qos_schedulers }}"
 
 - name: Prepare QoS schedulers for policy definition
-  set_fact:
+  ansible.builtin.set_fact:
     policy_qos_schedulers: "{{ policy_qos_schedulers | default([]) + [qos_scheduler] }}"
   loop: "{{ created_class_map_lists.results }}"
   vars:
@@ -86,7 +86,7 @@
   register: created_qos_map
 
 - name: Prepare rewrite rules for policy definition
-  set_fact:
+  ansible.builtin.set_fact:
     policy_rewrite_rules: "{{ policy_rewrite_rules | default([]) + rewrite_rules }}"
   loop: "{{ created_class_map_lists.results }}"
   when: item.item.queue > 0