[FEATURE REQUEST]: NTP config and terraform parallelism

[adc-nerd]

Description

NTP server config need to be applied one by one - by design.
The feature request is to honor this in the provider.

Affected Resource(s) and/or Data Source(s)

citrixadc_ntpserver

Equivalent NetScaler CLI Command

add ntp server ...

Potential Terraform Configuration

resource "citrixadc_ntpserver" "tf_ntp_server" {
    for_each = {
        for cfg in local.all_ntp_servers.value :
            cfg.servername => cfg
    }
    servername          = each.value.servername
    preferredntpserver  = each.value.preferredntpserver
}

References

By default, configuring multiple NTP servers in parallel fails with the following error message:

¦ Error: [ERROR] nitro-go: Failed to create resource of type ntpserver, name=my-ntp2.dom.dom, err=failed: 599 Netscaler specific error ({ "errorcode": 293, "message": "Operation already in progress", "severity": "ERROR" })

The workaround is to disable the parallelism i.e.: terraform apply -parallelism=1
This disables parallel processing for all resources, even though it is only needed for the NTP servers.

In addition there's currently also a limit of 31 characters for ntp servernames (RFE 1a5d30ea).