Skip to content

Commit 4860ecd

Browse files
committed
PushGateway: fixed grouping key logic and forced text format
New default is protobuf
1 parent ffe7982 commit 4860ecd

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

src/iapetos/export.clj

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
(ns iapetos.export
22
(:require [iapetos.registry :as registry])
3-
(:import [io.prometheus.metrics.exporter.pushgateway PushGateway]
3+
(:import [io.prometheus.metrics.exporter.pushgateway Format PushGateway]
44
[io.prometheus.metrics.expositionformats PrometheusTextFormatWriter]
55
[io.prometheus.metrics.model.registry PrometheusRegistry]
66
[java.io ByteArrayOutputStream]))
@@ -78,10 +78,11 @@
7878
(defn- with-grouping-key
7979
[gateway-builder grouping-key]
8080
(loop [builder gateway-builder
81-
gkey (first grouping-key)]
82-
(if-let [[k v] gkey]
83-
(recur (.groupingKey builder (name k) (str v)) (rest grouping-key))
84-
builder)))
81+
gkeys grouping-key]
82+
(let [[k v] (first gkeys)]
83+
(if-not (or (nil? k) (nil? v))
84+
(recur (.groupingKey builder (name k) (str v)) (rest gkeys))
85+
builder))))
8586

8687
(defn- as-push-gateway
8788
^PushGateway
@@ -90,6 +91,7 @@
9091
gateway
9192
(-> (PushGateway/builder)
9293
(.address ^String gateway)
94+
(.format Format/PROMETHEUS_TEXT)
9395
(.registry ^PrometheusRegistry (registry/raw registry))
9496
(.job ^String job)
9597
(with-grouping-key grouping-key)

0 commit comments

Comments
 (0)