Skip to content

Commit e696b50

Browse files
KauzClayaramprice
authored andcommitted
ci: normalize base image consumption
* extract yaml anchors to make future updates easier Signed-off-by: Aram Price <[email protected]>
1 parent 2ce620a commit e696b50

File tree

6 files changed

+17
-15
lines changed

6 files changed

+17
-15
lines changed

ci/dockerfiles/docker-cpi/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# this image builds bosh/docker-cpi
22
# it is used across ci to start a bosh in a docker container
3-
ARG BASE_IMAGE=bosh/integration:main
3+
ARG BASE_IMAGE
44
FROM $BASE_IMAGE
55

66
RUN docker_gpg="/etc/apt/trusted.gpg.d/docker.gpg" \

ci/dockerfiles/integration/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# ghcr.io/cloudfoundry/bosh/integration:main
2-
ARG BASE_IMAGE=ubuntu:jammy
2+
ARG BASE_IMAGE
33
FROM $BASE_IMAGE
44

55
ARG BOSH_CLI_URL

ci/dockerfiles/main-mysql/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
ARG BRANCH
2-
FROM bosh/integration:${BRANCH}
1+
ARG BASE_IMAGE
2+
FROM $BASE_IMAGE
33

44
# Install Dependencies
55
RUN echo 'mysql-server mysql-server/root_password password password' | debconf-set-selections

ci/dockerfiles/main-postgres/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
ARG BRANCH
2-
FROM bosh/integration:${BRANCH}
1+
ARG BASE_IMAGE
2+
FROM $BASE_IMAGE
33

44
ARG DB_VERSION
55

ci/dockerfiles/warden-cpi/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
ARG BASE_IMAGE=ghcr.io/cloudfoundry/bosh/integration:main
1+
ARG BASE_IMAGE
22
FROM $BASE_IMAGE
33

44
RUN apt-get update -y \

ci/pipeline.yml

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1116,7 +1116,7 @@ jobs:
11161116
params:
11171117
bump: patch
11181118

1119-
- name: build-integration
1119+
- name: build-integration-jammy
11201120
public: true
11211121
serial: true
11221122
plan:
@@ -1147,12 +1147,14 @@ jobs:
11471147
params:
11481148
build: .
11491149
build_args_file: docker-build-args/docker-build-args.json
1150+
build_args:
1151+
BASE_IMAGE: *ubuntu_base_jammy
11501152
dockerfile: bosh-ci-dockerfiles/ci/dockerfiles/integration/Dockerfile
11511153
tag_as_latest: true
11521154
get_params:
11531155
skip_download: true
11541156

1155-
- name: build-integration-noble
1157+
- name: build-integration
11561158
public: true
11571159
serial: true
11581160
plan:
@@ -1198,7 +1200,7 @@ jobs:
11981200
build: "bosh-ci-dockerfiles/ci/dockerfiles/main-postgres"
11991201
build_args:
12001202
DB_VERSION: "13"
1201-
BRANCH: ((branch_name))
1203+
BASE_IMAGE: *integration_image
12021204
get_params:
12031205
skip_download: true
12041206

@@ -1216,7 +1218,7 @@ jobs:
12161218
build: "bosh-ci-dockerfiles/ci/dockerfiles/main-postgres"
12171219
build_args:
12181220
DB_VERSION: "15"
1219-
BRANCH: ((branch_name))
1221+
BASE_IMAGE: *integration_image
12201222
get_params:
12211223
skip_download: true
12221224

@@ -1233,7 +1235,7 @@ jobs:
12331235
tag_as_latest: true
12341236
build: "bosh-ci-dockerfiles/ci/dockerfiles/main-mysql"
12351237
build_args:
1236-
BRANCH: ((branch_name))
1238+
BASE_IMAGE: *integration_image
12371239
get_params:
12381240
skip_download: true
12391241

@@ -1258,7 +1260,7 @@ jobs:
12581260
build: docker-build-context
12591261
build_args:
12601262
BASE_IMAGE: *integration_image
1261-
tag_as_latest: false
1263+
tag_as_latest: true
12621264
get_params:
12631265
skip_download: true
12641266

@@ -1284,7 +1286,7 @@ jobs:
12841286
build: docker-build-context
12851287
build_args:
12861288
BASE_IMAGE: *integration_image_jammy
1287-
tag_as_latest: true
1289+
tag_as_latest: false
12881290
get_params:
12891291
skip_download: true
12901292

@@ -1335,7 +1337,7 @@ jobs:
13351337
build: docker-build-context
13361338
build_args:
13371339
BASE_IMAGE: *integration_image_jammy
1338-
tag_as_latest: true
1340+
tag_as_latest: false
13391341
get_params:
13401342
skip_download: true
13411343

0 commit comments

Comments
 (0)